Item909: VIEW_TEMPLATE overrides preview template, leaving out all topic actions

Priority: Urgent
Current State: Closed
Released In:
Target Release: patch
Applies To: Engine
Component:
Branches:
Reported By: IsaacLin
Waiting For: Foswiki:Main.ArthurClemens
Last Change By: KennethLavrsen
When editing Item906 in the Tasks web, selecting the "Preview" button displayed a page that looked like the result of saving a page, not the usual Preview page. In the breadcrumb trail, after the topic name "Item906", the text "(revision 0)" appears. The changes that were made are displayed; however, the page had not actually been modified.

-- IsaacLin - 30 Jan 2009

I see, pressing Preview saves the page. This might be caused by FoswikiSiteSkin I don't see this on my test environment. Must be something on the site.

-- ArthurClemens - 07 Feb 2009

Selecting "Preview" shows you a screen that looks like the page is saved, but does not actually save it. I have experienced this again with HowToRunVirtualMachineImageOnVirtualBox.

-- IsaacLin - 10 Feb 2009

I would like to see if others also have this problem on their sites. Raising to urgent.

-- ArthurClemens - 11 Feb 2009

This is not specific to foswiki.org.

The preview is using the view_template for the preview screen. however the skin templates do not distinguish them, i.e. it does not keep the submitted data in a hidden form. It needed special provisions in natskin to detect the view templates being called in a preview context.

See Item6039

-- MichaelDaum - 11 Feb 2009

Do you have a pointer to those changes?

-- ArthurClemens - 11 Feb 2009

This is the same as the last issue added to Item726.

-- TimotheLitt - 11 Feb 2009

It is a unique Foswiki.org issue. The bug is not in Pattern Skin. It is working as it should in a normal installation with pattern.

So not a release blocker. Re assigning to the FoswikiSiteSkin


I am not convinced. I would like to test this further.

-- ArthurClemens - 12 Feb 2009

This also happens in default skin and pattern skin. The view template overrules the preview template, which leads to an unexpected screen and because users will not understand this they think the page is saved which it isn't. Danger of data loss. Raising to urgent again.

-- ArthurClemens - 13 Feb 2009

I think the solution is to let Preview not load the entire (custom) view template, but only the DEF 'content'. That content will then be rendered in the skin, surrounded by nothing more than the topic action buttons.

-- ArthurClemens - 13 Feb 2009

ItemTemplate edit

Summary VIEW_TEMPLATE overrides preview template, leaving out all topic actions
ReportedBy IsaacLin
Codebase
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Engine
Component
Priority Urgent
CurrentState Closed
WaitingFor Foswiki:Main.ArthurClemens
Checkins distro:2c33b4561e21 distro:ccd2653fd1c0 distro:ba5d5cf7be35 distro:3e243ac6826e
TargetRelease patch
ReleasedIn
Topic revision: r23 - 23 Feb 2009, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License