Item9025: Username is blank when login template is re-displayed after login failure

Priority: Low
Current State: Closed
Released In: 1.0.10, 1.1.0
Target Release: patch
Applies To: Engine
Component: login.tmpl
Reported By: BryanThale
Waiting For:
Last Change By: KennethLavrsen
The username field of the login form generated by login.tmpl is blank when the login page is re-displayed after a login attempt fails even though the template looks like it is trying to provide a value for the form field.

There are two problems:
  1. login.tmpl refers to a non-existent URL parameter 'usernamestep' which is a template block, not a URL parameter
  2. strips the username parameter from the request before displaying the login page

Since the login stuff looks like it is being actively modified for other reasons I've attached this diff of proposed changes rather than interfering with the ongoing work.

-- BryanThale - 15 May 2010

mmm, rather than renaming what is probably a very long time urlparam - usernamestep, I'm just going to use that in the code (thus reducing the breakage for other skins that c&p the core tmpls).

good catch - I wonder how long that's not worked.

added default param setting for reset password links, and a little docco

if anyone's eager, writing a unit test to show that it works would be nice smile setting to waiting for 1.0.10 release in case

-- SvenDowideit - 20 May 2010

It was imported from that other wiki project that way so somewhere between 4.1.0 and the fork. 2 or 3 years maybe.

I doubt usernamestep was ever a valid a URL param but I suppose someone could have used it and what's in a name after all? wink

-- BryanThale - 20 May 2010

ItemTemplate edit

Summary Username is blank when login template is re-displayed after login failure
ReportedBy BryanThale
Codebase 1.0.9, trunk
SVN Range 14-7376
AppliesTo Engine
Component login.tmpl
Priority Low
CurrentState Closed
Checkins distro:89b0bbd8db72 distro:3fcf5c2b964c distro:02aeebd52c24 distro:bea62ff759ec
TargetRelease patch
ReleasedIn 1.0.10, 1.1.0
I Attachment Action Size Date Who Comment
item9025.diffdiff item9025.diff manage 1 K 16 May 2010 - 00:14 BryanThale Diff of changes versus trunk@7433
Topic revision: r8 - 08 Sep 2010, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy