Item9025: Username is blank when login template is re-displayed after login failure
Current State: Closed
Released In: 1.0.10, 1.1.0
Target Release: patch
Applies To: Engine
Component: login.tmpl TemplateLogin.pm
The username field of the login form generated by login.tmpl is blank when the login page is re-displayed after a login attempt fails even though the template looks like it is trying to provide a value for the form field.
There are two problems:
- login.tmpl refers to a non-existent URL parameter 'usernamestep' which is a template block, not a URL parameter
- TemplateLogin.pm strips the username parameter from the request before displaying the login page
Since the login stuff looks like it is being actively modified for other reasons I've attached this diff of proposed changes rather than interfering with the ongoing work.
- 15 May 2010
mmm, rather than renaming what is probably a very long time urlparam -
, I'm just going to use that in the code (thus reducing the breakage for other skins that c&p the core tmpls).
good catch - I wonder how long that's not worked.
added default param setting for reset password links, and a little docco
if anyone's eager, writing a unit test to show that it works would be nice
setting to waiting for 1.0.10 release in case
- 20 May 2010
It was imported from that other wiki project that way so somewhere between 4.1.0 and the fork. 2 or 3 years maybe.
was ever a valid a URL param but I suppose someone could have used it and what's in a name after all?
- 20 May 2010