Item8738: Passthrough isn't working correctly in validation

Somewhere along the line I changed the query passthrough URL param from 'originalquery' to 'foswikioriginalquery'. Unfortunately I missed one instance of it, and passthrough isn't working. I noticed the symptom when working on Item8503; when you save a topic with empty mandatory fields, then go back from the veto, then save again with the fields still empty, and OK the validation, it carries on but doesn't save anything; this is because the params passthrough uses 'foswikioriginalquery' but the validation code reads 'originalquery'.

-- CrawfordCurrie - 20 Mar 2010

Challenging debug revealed two problems; first, that the id of the passthrough param had changed inconsistently, so that passed-through data was being ignored and second, when the data did actually make it to a save, the field definition code was equating a param value of undef to the param being absent from the query, which is wrong; and undef value can be reloaded from a passthrough, and should be handled as the empty string. Without this correction, it would be impossible to clear a field when the request has gone through passthru, a problem observed on trunk.foswiki.org

I don't believe either of these problems would have affected 1.0.9 - they were both side-effects of other fixes to the passthrough code.

-- CrawfordCurrie - 20 Mar 2010

Commenting is disabled while not logged in