Item8253: History and Revision gets redirected when using REDIRECT

pencil
Priority: Normal
Current State: New
Released In:
Target Release:
Applies To: Extension
Component: RedirectPlugin
Branches:
Reported By: HolgerHain
Waiting For:
Last Change By: KennethLavrsen

Description

We use a %REDIRECT% to hide a topic ToDoList contaning all actions, so the users creating an action with an html form in the topic ToDo do not need to take care about the action-definitions. This works basically very nice and it is easy to view the topic ToDoList by the correct link (with attached ?noredirect=on).

Using uncorrect links such as .../ToDoList#000075 (i.e. the link from a specific action) the user gets redirected to the topic ToDoList. Thats not so nice but it is not the problem because the edit-link in the actionsearch output tables works fine.

The problem occurs when I try to view the topic ToDoList with specific parameters (i.e. ?rev=...) or compare revisions. Then you get redirected to the topic ToDo with the parameters for ToDoList (except for the comparison). It gets really messy if I use the HistoryPlugin to compare revisions.

Solutions

  1. add ?noredirect=on to all link buttons of "more topic actions" of that topic if ( isset ( %REDIRECT% ) )
  2. remove all options ?... from original URL when redirecting (i.e. /TopicX?redirectfrom=TopicY instead of /TopicX?redirectfrom=TopicY&option1=...)

-- HolgerHain - 25 Aug 2009

Interesting report, surprised no one has noticed this before.

I have worked out how the fix the Print and the History links using templates, but I don't know what to do about the r2 < r1 links.

These get generated somewhere in Foswiki (I guess hard coded) when the %REVISIONS% Macro is found, so I don't know how to override them from a Plugin. Maybe we need to build these links ourselves, using another Macro...

As for the HistoryPlugin, its not something I use so need to investigate separately.

I have checked in my fixes for Print and History.

-- AndrewJones - 26 Aug 2009

MailInContrib:acff590507f9 was SVN checked in to this item by mistake. It belongs to Item8523

-- KennethLavrsen - 21 Feb 2010
 

ItemTemplate edit

Summary History and Revision gets redirected when using REDIRECT
ReportedBy HolgerHain
Codebase 1.0.6
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Extension
Component RedirectPlugin
Priority Normal
CurrentState New
WaitingFor
Checkins RedirectPlugin:536eceb9e313
ReleasedIn
Topic revision: r7 - 21 Feb 2010, KennethLavrsen - This page was cached on 05 Jun 2020 - 19:00.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy