Item8238: FastCGIEngineContrib leaves warnings on webserver logs

Priority: Enhancement
Current State: Closed
Released In:
Target Release: n/a
Applies To: Extension
Component: FastCGIEngineContrib
Branches:
Reported By: Foswiki:Main.AntonioTerceiro
Waiting For: Foswiki:Main.ItaloValcy
Last Change By: ItaloValcy
They are like these:

[Wed Aug 12 10:23:53 2009] [warn] mod_fcgid: stderr: Use of uninitialized value $lastMTime in numeric gt (>) at /var/lib/foswiki/lib/Foswiki/Engine/FastCGI.pm line 118.
[Wed Aug 12 10:23:53 2009] [warn] mod_fcgid: stderr: Use of uninitialized value $mtime in numeric gt (>) at /var/lib/foswiki/lib/Foswiki/Engine/FastCGI.pm line 118.

-- AntonioTerceiro - 12 Aug 2009

That's strange, since both variables are initialized just before used. Probably the technique used to locate LocalSite.cfg is not reliable.

-- GilmarSantosJr - 13 Aug 2009

I have the same problem with my foswiki installation. Here, I'm using the foswiki debian package made by Sven and because the debian policy the configurations files are in /etc directory. I think that FastCGIEngineContrib assumes that LocalSite.cfg configuration file is in /foswikiroot/lib (the default place) what's incorrect for such cases.

So, I think this patch can help (its working for my installation):
Index: FastCGI.pm
===================================================================
--- FastCGI.pm  (revisão 4834)
+++ FastCGI.pm  (cópia de trabalho)
@@ -122,9 +122,7 @@
         $this->daemonize() if $args->{detach};
     }
 
-    my $localSiteCfg = File::Spec->catpath(
-        ( File::Spec->splitpath( $INC{'Foswiki.pm'} ) )[ 0, 1 ],
-        'LocalSite.cfg' );
+    my $localSiteCfg = $INC{'LocalSite.cfg'};
     my $lastMTime = ( stat $localSiteCfg )[9];
 
     while ( $r->Accept() >= 0 ) {

-- ItaloValcy - 11 Sep 2009

I applied the patch above and I released and uploaded a new version of this extension.

-- ItaloValcy - 21 Dec 2009

great! smile

-- AntonioTerceiro - 30 Dec 2009

Italo, I didn't see your new release with this fix; are you sure you did it? Please ping me if you need any help with it.

-- AntonioTerceiro - 04 Jan 2010

(e.g. FastCGIEngineContrib still lists Gilmar's release from Jan 2009)

-- AntonioTerceiro - 04 Jan 2010

CurrentState: Waiting for Release. Please set to Closed after the release wink

-- GilmarSantosJr - 04 Jan 2010

Since FastCGIEngineContrib was not released including this fix, I'll leave it as Waiting for Release as a remind note. TargetRelease is n/a, since it is a extension that is not part of a standard Foswiki.

-- GilmarSantosJr - 05 Jan 2010

Well, I think that its correct now (upload and release). Could someone check it? I'll wait any feedback to set this task to Closed.

-- ItaloValcy - 06 Jan 2010

I didn't test the package, but it has the changes you made. I think you can close this task. Thanks for your contribution!

-- GilmarSantosJr - 06 Jan 2010
 
Topic revision: r19 - 07 Jan 2010, ItaloValcy
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License