Item8084: Confusing "Bad request" during upgrade when going 3048 => 3236

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Normal Closed Engine    
Confusing "Bad request (malformed multipart POST)" messages during upgrades.

Also, I was surprised that it updated WysiwygPlugin as configure had not said it was needed to be upgraded, and not asked me for confirmation.

Foswiki::Plugins::WysiwygPlugin version 16650 required--this is only version 36.082101118058

  • Removed most of the noise in this bug report to keep only relevant information -- OlivierRaginel - 07 Jul 2009

Foswiki logo
Fetching http://foswiki.org/pub/Extensions/TinyMCEPlugin/TinyMCEPlugin.tgz...
Unpacking...
pub/
pub/System/
pub/System/TinyMCEPlugin/

Note: Existing pub/System/TinyMCEPlugin/foswiki.js overwritten. Backup saved in /home/foswiki/htdocs/foswiki/pub/System/TinyMCEPlugin/foswiki.js.bak
[zip]
TinyMCEPlugin_installer

Running from configure, disabling CPAN

### TinyMCEPlugin Installer ###

This installer must be run from the root directory of your Foswiki
installation.
    * You can abort the script at any point and re-run it later
    * If you answer 'no' to any questions you can always re-run
      the script again later
##########################################################
Checking dependency on Foswiki::Plugins::BehaviourContrib....
*** TinyMCEPlugin depends on perl package Foswiki::Plugins::BehaviourContrib >=15357
which is described as "Javascript module"
But when I tried to find it I got this error:

Can't locate Foswiki/Plugins/BehaviourContrib.pm

Downloaded installer from http://foswiki.org/pub/Extensions to /home/foswiki/htdocs/foswiki/BehaviourContrib_installer
Content-Length: 408
Status: 400
Content-Type: text/html; charset=ISO-8859-1







Bad Request

Bad request (malformed multipart POST)

### BehaviourContrib Installer ###
[zip ... normal installer output ... ]

Content-Length: 408
Status: 400
Content-Type: text/html; charset=ISO-8859-1







Bad Request

Bad request (malformed multipart POST)

##########################################################
Checking dependency on Foswiki::Plugins::WysiwygPlugin....
*** TinyMCEPlugin depends on perl package Foswiki::Plugins::WysiwygPlugin >=16650
which is described as "Translator module"
But when I tried to find it I got this error:

Foswiki::Plugins::WysiwygPlugin version 16650 required--this is only version 36.082101118058
Downloaded installer from http://foswiki.org/pub/Extensions to /home/foswiki/htdocs/foswiki/WysiwygPlugin_installer
Content-Length: 408
Status: 400
Content-Type: text/html; charset=ISO-8859-1







Bad Request

Bad request (malformed multipart POST)

### WysiwygPlugin Installer ###

This installer must be run from the root directory of your Foswiki
installation.
    * You can abort the script at any point and re-run it later
    * If you answer 'no' to any questions you can always re-run
      the script again later
##########################################################
Checking dependency on HTML::Parser....
HTML::Parser v3.55 loaded
##########################################################
Checking dependency on HTML::Entities....
HTML::Entities v1.35 loaded
##########################################################
Checking dependency on Encode....
Encode v2.12 loaded
I will keep a backup of any files I overwrite.Fetching the archive for Foswiki::Plugins::WysiwygPlugin.
Downloaded archive from http://foswiki.org/pub/Extensions to /home/foswiki/htdocs/foswiki/WysiwygPlugin.tgz
[zip ... normal installer output ... ]
Content-Length: 408
Status: 400
Content-Type: text/html; charset=ISO-8859-1







Bad Request

Bad request (malformed multipart POST)

I will keep a backup of any files I overwrite.Fetching the archive for Foswiki::Plugins::TinyMCEPlugin.
Downloaded archive from http://foswiki.org/pub/Extensions to /home/foswiki/htdocs/foswiki/TinyMCEPlugin.tgz
[zip ... normal installer output ... ]

Installer ran without errors
Installation finished.

Note: Before you can use newly installed plugins, you must enable them in the "Plugins" section in the main page.
Return to configuration
 

-- MartinCleaver - 24 Mar 2009

Looking at this example I want to add this comment.

  • Downloading and installing extensions other than what you ask for is wrong. At least people need to be prompted so you can say no. I once installed an extension and ended up with GluePlugin even though it was not really needed other than for examples. Since then my production site is always having extensions added manually. I would prefer being prompted or guided to installing additional items.
  • Extension installation via configure generates a gzillion .bak files. It is a mess to clean up afterwards.
  • Things are not very stable still.

When I guide people on IRC I advice to manually install still.

-- KennethLavrsen - 24 Mar 2009

This is a general problem, not specific to TinyMCEPlugin. Extension installation has received a lot of work recently; see if you can manage to encourage it, rather than damning it.

-- CrawfordCurrie - 10 Apr 2009

Yes, and this "Bad request" is really odd, and hasn't been tracked down yet. It doesn't mean one should discourage configure. Bug reports are always welcomed.

Problem here is that you can't really ask the user much, or this would need a total re-write to be fully AJAX.

-- OlivierRaginel - 07 Jul 2009

I am usually using configure for installing extensions and by now have seen a "Bad Request" in several if not many cases. Just today again by installing the VotePlugin. Since it depends on the RatingContrib this was in addition automatically installed which I considered to be a feature though it could be useful to ask for confirmation.

-- IngoKappler - 30 Jul 2009

Thanks to great logs from JanDreyer, I managed to identify the culprit as being LWP, mostly caused by the underlying CGI call. Changed the code to be more helpful, and will see if we can fix it.

-- OlivierRaginel - 06 Nov 2009

By finding and uniquely changing every place 'Bad Request' occurs in the code, this message is coming from Engine.pm, in the prepare() routine. I don't see anywhere in Configure where a new Foswiki::Request object is created, but the error is definitely coming from this routine, due to a Foswiki::EngineException. This bug has nothing to do with LWP that I can see.

Is configure even supposed to be invoking the Foswiki engine?

-- GeorgeClark - 13 Nov 2009

Just needed to specify the Foswiki Engine before calling Foswiki. CLI is the way.

Fixed a lot of other issues along the way...

-- OlivierRaginel - 25 Nov 2009

ItemTemplate edit

Summary Confusing "Bad request" during upgrade when going 3048 => 3236
ReportedBy Foswiki:Main.MartinCleaver
Codebase 1.0.7, trunk
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Engine
Component
Priority Normal
CurrentState Closed
WaitingFor
Checkins Foswikirev:5632 Foswikirev:5633 Foswikirev:5634 Foswikirev:5635 Foswikirev:5636 Foswikirev:5637 Foswikirev:5638 Foswikirev:5639 Foswikirev:5647
TargetRelease patch
ReleasedIn 1.0.8, 1.1.0
Topic revision: r26 - 29 Nov 2009, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License