Item781: Forms fields expand variables like , "e %

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Urgent Closed Engine    
From TWikibug:Item6167: TWiki Forms expand variables like $nop, $quote $percnt

This is confirmed.

Formfields that contains standard escaped dollar strings are escaped in the META tag. They should not be EXCEPT when using META with the option parent.

In TWikibug:5288 someone reported it as an error that the standard escapes are not escaped with the "parent" option. And this bug was correct.

Unfortunately the developers that fixed it escaped the dollar strings in all cases which also means in forms.

The spec clearly says only with the parent which is the only option that takes an additional format parameter and it is in the format that we escape these strings.

I have tried to make a unit test for this but I have not been successful yet. I will ask for help with that and add it later. For now we need it fixed

I have commented in the code to minimize risk of reimplementing this bug for the 3rd time.

-- KennethLavrsen - 16 Jan 2009

As a note. The additional fixes Sopan added on TWikibug:Item6167 are not needed on Foswiki. Our code seems to work correctly for the Search also with the fixes I applied on this bug item.

In fact Sopan fails to fix the real issue that introduced the problem in the first place.

-- KennethLavrsen - 21 Jan 2009

ItemTemplate edit

Summary Forms fields expand variables like $nop, $quote $percnt
ReportedBy KennethLavrsen
Codebase trunk
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Engine
Component
Priority Urgent
CurrentState Closed
WaitingFor
Checkins Foswikirev:1996
TargetRelease patch
ReleasedIn 1.0.1
Topic revision: r4 - 23 Feb 2009, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License