cross
New Foswiki release 2.1.6 is available with important security fixes.
Sourceforge foswiki email lists being discontinued. Subscribe to the new Foswiki announce and discuss lists at MailingLists
You are here: Foswiki>Tasks Web>Item750 (23 Feb 2009, KennethLavrsen)Edit Attach

Item750: INCLUDINGWEB and INCLUDINGTOPIC will cause confusion when used in an INCLUDE chain

pencil
Priority: Urgent
Current State: Closed
Released In: 1.0.1
Target Release: patch
Applies To: Engine
Component: System web topics
Branches:
Reported By: SvenDowideit
Waiting For:
Last Change By: KennethLavrsen

what i should have written :/

topics that use INCLUDING* will trip up users - especially when they include something that is already INCLUDED - consider someone making a rss feed, so they INCLUDE Main's rss topic - they get a topic that show's Main's rss feed (until i fixed WebRssBase to use BASEWEB)

original bug report

because System . WebChanges uses INCLUDINGWEB, which is the next WEB up the INCLUDE chain, a topic that includes a topic that includes WebChanges will not do what it should.

WebChanges, and all the System web topics need to be converted from INCLUDINGWEB to BASEWEB for 1.0.1 .

this bug means anyone using topics that point to WebChanges will see the TWiki web's changes, not what it used to - so urgent !

-- SvenDowideit

Good catch. To assist and get it closed I did this one

-- KennethLavrsen - 13 Jan 2009

there are alot more topics with the same problem,

basically, all Web* topics are likely to be included in a chain. for eg, WebRss may be made by the user INCLUDING{Main.WebRss} which then INCLUDES{System.WebRss} - resulting in their rss feed saying that they are getting the changes of the 'Main' web.

same issue wrt INCLUDINGTOPIC, but even more subtle

but i've found a further oddity if you INCLUDE{System.Macros} - see Item771

-- SvenDowideit - 15 Jan 2009

ok, so the Web* topics are all done, and Item771 deals with the related issues for the Var* topics.

-- SvenDowideit - 05 Feb 2009

ItemTemplate edit

Summary INCLUDINGWEB and INCLUDINGTOPIC will cause confusion when used in an INCLUDE chain
ReportedBy SvenDowideit
Codebase 1.0.0, trunk
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Engine
Component System web topics
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:852f7b57502b distro:be2067a2ce59 distro:326446cd2f7c distro:728c715abc83 distro:b2f4c0024a82
TargetRelease patch
ReleasedIn 1.0.1
Topic revision: r14 - 23 Feb 2009, KennethLavrsen - This page was cached on 15 Aug 2018 - 01:29.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy