Item569: ENCODE turns the value 0 into empty string ''

Priority: Normal
Current State: Closed
Released In: 1.0.0
Target Release: patch
Applies To: Engine
Component:
Branches:
Reported By: Foswiki:Main.KennethLavrsen
Waiting For:
Last Change By: KwangErnLiew
In Item5453 a general issue is raised which is that some macros are not handling the value 0 as a string but as the value false.

This causes for example ENCODE to convert 0 to ''

As Sven rightfully says this can be a can of worms.

But I believe the best is to take them one at a time - and take the first one as the one that seems to have caused problems already in reports.

And the 5453 reports the ENCODE as the problem

I could not follow up with unit tests etc and other may follow up. I think a simple little comment in the code where I fix it will prevent the bug from coming back.

I will checkin the school book fix for how to handle a variable that can be 0.

The general way is

$a = defined ( $b ) ? $b : '';

I create this bug report so I can put it Waiting for Release and get the happy news about ENCODE in the release note.

If I check in on 5453 I cannot close the bug and it will not be in the release note.

-- KennethLavrsen - 25 Dec 2008

ItemTemplate edit

Summary ENCODE turns the value 0 into empty string ''
ReportedBy Foswiki:Main.KennethLavrsen
Codebase trunk
SVN Range TWiki-4.2.3, Wed, 06 Aug 2008, build 17396
AppliesTo Engine
Component
Priority Normal
CurrentState Closed
WaitingFor
Checkins
TargetRelease patch
ReleasedIn 1.0.0
Topic revision: r2 - 08 Jan 2009, KwangErnLiew
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License