You are here: Foswiki>Tasks Web>Item568 (25 Dec 2008, RaulFRodriguez)Edit Attach

Item568: When switching to other languages, the top buttons "Edit" and "Attach" do not display correctly the defined access key in some languages

Priority: Urgent
Current State: Closed
Released In: 1.0.0
Target Release: patch
Applies To: Engine
Reported By: RaulFRodriguez
Waiting For:
Last Change By: RaulFRodriguez
When switching to other languages, the top buttons "Edit" and "Attach" do not display correctly the text if the access key defined after the "&". The access key defined after the "&" drops down under the button, and a letter is missing inside the button.

This happens if the letter after the "&" in the translation is not "E" or "A" (case sensitive). This can be seen there:

Earlier, its used to be possible to set the access key to a letter in the middle of the word, such as in French "Modifi&er" instead of "&Edit". Now, the same HMTL rendered (viewing the source code, it looks exactly the same in an existing TWiki installation with the same strings) produces a different output.

What is seen there is different:

The buttons are correctly displayed ... but the access key is "a" for "Attach", while in the translated string it is "&Utwórz załącznik". This is an inconsistency, since the translated string in pl.po is: msgstr "title='Utwórz załącznik do strony' accesskey='a'>&Utwórz załącznik" - but the point is that it appears that if the letter after the "&" is capitalized, the button is displayed correctly


it displays something very strange (a small "g" button in the "Edit" place and some Japanese kanjis without a button design in the "Attach" place). I don't know if the problem seen is related.

The result looks terrible, in the affected languages. So I guess this has to be corrected before the release.

If this is not a bug, and we are doing something wrong with the translated strings, please advise me, because I have taken the FR translation, and I will correct my translation accordingly. Nevertheless, I do not believe this is a problem with the translated text, since it was the same translated French text for these buttons in TWiki-4.2.3 and "Modifi&er" for "&Edit" was not producing any problem with the output.

-- RaulFRodriguez - 24 Dec 2008

It was Arthur Clemens checkin distro:e864c0d6ce43 that goofed this one up.

It is as usually quite a lot of changes checked in at the same time (buh) and I have not been able to isolate exactly which change causes this.

I have studied the generated HTML and it is identical from what used to work.

It is a CSS related issue. And as far as I can see related to the style patternToolBar

Arthur is away for another week at least and this is a nasty release blocker. Who knows CSS enough to help?

-- KennethLavrsen - 25 Dec 2008

Thank you Kenneth. That's much better!

A problem still appears with the Japanese translation, but I think I may be related to the way the strings are translated. I fear I do not know any Japanese, so I can't help with that. KenYuminaga, who was the Japanese translator for TWiki does not appear to be registered on Foswiki. I will send an e-mail and copy AndreUlrich who is coordinating the translation efforts.

Oh,... and Merry Christmas if you celebrate it!

-- RaulFRodriguez - 25 Dec 2008

ItemTemplate edit

Summary When switching to other languages, the top buttons "Edit" and "Attach" do not display correctly the defined access key in some languages
ReportedBy RaulFRodriguez
Codebase trunk
SVN Range Revision 1571: /trunk
AppliesTo Engine
Priority Urgent
CurrentState Closed
Checkins distro:bbf8b7778ba5
TargetRelease patch
ReleasedIn 1.0.0
Topic revision: r4 - 25 Dec 2008, RaulFRodriguez
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy