Item5163: SpreadSheetPlugin causes table to misrender an empty row

pencil
Priority: Normal
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Extension
Component: SpreadSheetPlugin
Branches:
Reported By: TWiki:Main.ArthurClemens
Waiting For:
Last Change By: KennethLavrsen
Test table:

Row 1 of 2

Test Calc:

The last row is not rendered as empty row.

-- TWiki:Main/ArthurClemens - 21 Dec 2007

I just tested on Cairo and on 4.1, same issue. That is, this is a bug that existed for a long time but was discovered just now.

Reprioritizing to normal per decision at TWiki:Codev/FreetownReleaseMeeting2008x01x07

-- TWiki:Main.PeterThoeny - 07 Jan 2008

Maybe Item5217 isn't a problem with EditTablePlugin at all but has to do with the rendering of 'empty' cells? -- Just guessing. smile

-- TWiki:Main.FranzJosefGigler - 08 Jan 2008

No, the TML spec is clear. An empty cell means merge cell with cell on the left.

Without the %CALC the empty cell is not rendered.

With the %CALC the empty cell seems to loose its right bar and becomes a bar.

it does not happen with a table with two columns. It does not happen if the cell contains any text or a space. It only happens when you have a table where the last row is a merged single cell. It does not happen if the last row is a table with data in a column and then an empty merged cell. I can only trigger the bug when it is a single column table where the last row is empty. Why would you have an empty row which is not displayed.

So no need to hurry fixing this. It is a very exotic bug.

-- TWiki:Main.KennethLavrsen - 08 Jan 2008

Peter Thoeny fixed this with the following patch:

Modified: twiki/trunk/SpreadSheetPlugin/lib/TWiki/Plugins/SpreadSheetPlugin/Calc.pm
===================================================================
--- twiki/trunk/SpreadSheetPlugin/lib/TWiki/Plugins/SpreadSheetPlugin/Calc.pm   2010-06-24 05:55:47 UTC (rev 19121)
+++ twiki/trunk/SpreadSheetPlugin/lib/TWiki/Plugins/SpreadSheetPlugin/Calc.pm   2010-06-26 01:28:48 UTC (rev 19122)
@@ -106,6 +106,7 @@
                 $line =~ s/^(\s*\|)(.*)\|\s*$/$2/o;
                 $before = $1;
                 @row  = split( /\|/o, $line, -1 );
+                $row[0] = '' unless( @row );
                 push( @tableMatrix, [ @row ] );
                 $rPos++;
                 $line = "$before";

-- CrawfordCurrie - 26 Jun 2010

ItemTemplate edit

Summary SpreadSheetPlugin causes table to misrender an empty row
ReportedBy TWiki:Main.ArthurClemens
Codebase
SVN Range TWiki-4.3.0, Tue, 18 Dec 2007, build 16029
AppliesTo Extension
Component SpreadSheetPlugin
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:5618a153e5e4
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r8 - 04 Oct 2010, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy