You are here: Foswiki>Tasks Web>Item3908 (06 Jan 2015, GeorgeClark)Edit Attach

Item3908: Possible to set a topic parent to itself

pencil
Priority: Low
Current State: Confirmed
Released In: n/a
Target Release: n/a
Applies To: Engine
Component: FoswikiUsability
Branches:
Reported By: TWiki:Main.ArthurClemens
Waiting For:
Last Change By: GeorgeClark
This is mainly a UI errror. It can be prevented by omitting the current topic from TOPICLIST, for instance with an omittopic parameter.

-- TWiki:Main/ArthurClemens - 15 Apr 2007

we should protect against this in the save code (or topic meta) too really, as this is a 'data integrity' issue.

-- TWiki:Main.SvenDowideit - 16 Apr 2007

This is the simplest possible example of a cycle in parent relationships. Anything that uses parent relationships needs to be aware of the possibility of cycles; I don't think it's TWiki's job to ensure that there are none in the saved data, even if it could. I'm going to reject this. If you can justify why I shouldn't, then please re-open it.

-- TWiki:Main.CrawfordCurrie - 26 Apr 2007

You can at least prevent the current topic from being selected as parent.

-- TWiki:Main.ArthurClemens - 26 Apr 2007

I had a problem with such a dependency. I know it was my fault but I think TWiki should not allow to do what I have done. I have removed the topic "WebHome" of a web because the only child (let's call that topic "Child") of that topic should be moved to "WebHome" in order to keep the history. The parent of Child was WebHome so after the move of Child to WebHome was it's own parent. I could not change the dependency because the topic could not be shown anymore. I had to change the file directly on the server. At first, I did not even know why the topic was hanging. I think TWiki should not allow that a topic is its own parent. There should be a check and a error message.

-- TWiki:Main.KirstinWeber - 30 Jul 2008

This means there are 3 use cases (up to now) where a topic can be set as parent to itself:
  1. Setting a parent through the interface (dropdown list)
    • Topic list can be altered, so not to show the current topic
  2. Setting a parent through a web form, setting topicparent
    • Could give a warning (oops?)
  3. Renaming a topic to its parent
    • Should be handled by the renaming code, possibly a warning

-- ArthurClemens - 18 Nov 2008 - 21:42

ItemTemplate edit

Summary Possible to set a topic parent to itself
ReportedBy TWiki:Main.ArthurClemens
Codebase
SVN Range TWiki-4.1.2, Sun, 15 Apr 2007, build 13419
AppliesTo Engine
Component FoswikiUsability
Priority Low
CurrentState Confirmed
WaitingFor
Checkins
TargetRelease n/a
ReleasedIn n/a
CheckinsOnBranches
trunkCheckins
masterCheckins
ItemBranchCheckins
Release01x01Checkins
Topic revision: r8 - 06 Jan 2015, GeorgeClark - This page was cached on 26 Jan 2021 - 14:21.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy