Item3908: Possible to set a topic parent to itself
Current State: Confirmed
Released In: n/a
Target Release: n/a
This is mainly a UI errror. It can be prevented by omitting the current topic from
, for instance with an
- 15 Apr 2007
we should protect against this in the save code (or topic meta) too really, as this is a 'data integrity' issue.
- 16 Apr 2007
This is the simplest possible example of a cycle in parent relationships. Anything that uses
parent relationships needs to be aware of the possibility of cycles; I don't think it's TWiki's job to ensure that there are none in the saved data, even if it could. I'm going to reject this. If you can justify why I shouldn't, then please re-open it.
- 26 Apr 2007
You can at least prevent the current topic from being selected as parent.
- 26 Apr 2007
I had a problem with such a dependency. I know it was my fault but I think TWiki should not allow to do what I have done. I have removed the topic "WebHome" of a web because the only child (let's call that topic "Child") of that topic should be moved to "WebHome" in order to keep the history. The parent of Child was WebHome
so after the move of Child to WebHome
was it's own parent. I could not change the dependency because the topic could not be shown anymore. I had to change the file directly on the server. At first, I did not even know why the topic was hanging. I think TWiki should not allow that a topic is its own parent. There should be a check and a error message.
- 30 Jul 2008
This means there are 3 use cases (up to now) where a topic can be set as parent to itself:
- Setting a parent through the interface (dropdown list)
- Topic list can be altered, so not to show the current topic
- Setting a parent through a web form, setting
- Could give a warning (oops?)
- Renaming a topic to its parent
- Should be handled by the renaming code, possibly a warning
- 18 Nov 2008 - 21:42