Foswiki on GitHub is open for business! Next release meeting: Monday September 29, 1300Z

Item244: nonwikiword is never really checked

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Normal Closed Engine    
At a number of places there is a checkbox "Allow non WikiWord for the new topic name". This setting is actually not checked when creating a topic, except for rename where this concept originates. The code for checking is in Manage.pm.

Solution: enhance Manage by creating subroutines for topic creation. Add the check in that routine.

-- ArthurClemens - 22 Nov 2008 - 16:26

additional: it's also especially annoying when the topic that you're moving (which is a form of rename), is already a non-WikiWord and the checkbox isn't checked by default and you get an error message when you simply select a new web to move the topic to.

  • This is a perfect example why moving != renaming. On the file level it is the same, on a conceptual level they are different and should be offered differently to the user. So when moving the rename option should not be displayed at all, unless you want to rename while moving. -- ArthurClemens - 23 Nov 2008 - 00:50

-- WillNorris - 22 Nov 2008 - 21:28

First pass:
  • added subroutine for copying topic, as this functionality was added in Item1873 but lacked a working check
    • TODO: document this
  • abstracted out the handling of param 'nonwikiword'

I will now continue on the topic creation. I imagine the html form like this:
<form action="%SCRIPTURL{manage}%/%WEB%/">
<input type="hidden" name="action" value="create" />
...
%TMPL:P{"nonwikiword"}%
</form>

-- ArthurClemens - 23 Nov 2008 - 00:34

I have generalized the copy subroutine to create topics so the form example above works for copying as well.

-- ArthurClemens - 23 Nov 2008

ItemTemplate edit

Summary nonwikiword is never really checked
ReportedBy ArthurClemens
Codebase
SVN Range TWiki-4.2.3, Wed, 06 Aug 2008, build 17396
AppliesTo Engine
Component
Priority Normal
CurrentState Closed
WaitingFor
Checkins Foswikirev:858 Foswikirev:875
TargetRelease patch
ReleasedIn
Topic revision: r10 - 08 Jan 2009, KwangErnLiew
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License