Item2413: When I use a script that uses oops to show results, the web page title is wrong.
Priority: Urgent
Current State: Closed
Released In: 1.0.8, 1.1.0
Target Release: patch
Applies To: Engine
Component:
Branches:
for example, if you use
BulkResetPassword, the resulting url is
manage/System/BulkResetPassword
, but the title at the top of my browser is
WebHome<Main<Foswiki
.
this is due to
core/templates/foswiki.tmpl
defining the title using
WEB
and
TOPIC
I think they should be
BASEWEB
and
BASETOPIC
I'd like a second opinion though.
trivial change:
sven@quad:/home/www/nextwiki/branches/Release01x00$ svn diff core/
Index: core/templates/foswiki.tmpl
===================================================================
--- core/templates/foswiki.tmpl (revision 5623)
+++ core/templates/foswiki.tmpl (working copy)
@@ -22,7 +22,7 @@
%TMPL:DEF{"script:skintemplate"}%%TMPL:END%
%TMPL:DEF{"script:topictemplate"}%%TMPL:END%
-%TMPL:DEF{"windowtitle"}%<title>%TMPL:P{"titleaction"}% <nop>%TOPIC%%TMPL:P{"titlesep"}%%WEB%%TMPL:P{"titlesep"}%<nop>%WIKITOOLNAME%</title>%TMPL:END%
+%TMPL:DEF{"windowtitle"}%<title>%TMPL:P{"titleaction"}% <nop>%BASETOPIC%%TMPL:P{"titlesep"}%%BASEWEB%%TMPL:P{"titlesep"}%<nop>%WIKITOOLNAME%</title>%TMPL:END%
%TMPL:DEF{"head"}%<head>
%TMPL:P{"windowtitle"}%
--
SvenDowideit - 25 Nov 2009
Agreed. TOPIC and WEB change as you move through the include chain; only BASEWEB and BASETOPIC are reliable.
--
CrawfordCurrie - 27 Nov 2009
commited
--
SvenDowideit - 29 Nov 2009