Item2337: ATTACHFILESIZELIMIT check fails confusingly if value is "0 "
If the user mistakenly sets ATTACHFILESIZELIMIT to the string "0 ", the file size check fails, but with a confusing error:
"Oversized file foo exceeds limit of 0 Kb.
Since there's no real visual clue that there's an extra space, this can cause some frustration. The attached patch strips trailing spaces from the value. I presume this is not done by the preference macro parsing code because trailing spaces might be useful in some contexts.
has the same issue.
Can't confirm the issue for UploadPlugin
: Setting ATTACHFILESIZELIMIT to 0 disables the check all together.
- 17 Nov 2009
Did you try the string "0 " (note the space at the end)?
- 16 Jan 2010
Was an easy fix. It is possible to add trailing spaces if you accidently edit a settings topic with Wysiwyg and the wrong browser so this is why I found it worth fixing in 1.0.9
- 17 Jan 2010
Re-opening because this has been fixed properly in the release branch, but the fix in trunk is wrong. So re-opening and fixing will NOT disrupt the release process, as this bug is closed, and has been closed for 1.0.9.
- 19 Jan 2010