Item1788: Enhance SmiliesPlugin so a definition table allows more columns with free text.

I tried to change the default topic for SmiliesPlugin and failed.

When using in SitePreferences:

   * %SYSTEMWEB%.SmiliesPlugin Settings
      * Set TOPIC = Main.SmiliesCustomized

Then it still refers as if it would be SmiliesPlugin.

When using:

   * %SYSTEMWEB%.SmiliesPlugin Settings
      * Set SMILIESPLUGIN_TOPIC = Main.SmiliesCustomized

Then it has the effect that no Smilies work at all.

Problem was that I put a forth column which destroyed somehow the parsing of the table. Lines with an added column didn't work at all:

| <nop>:-)          | %ATTACHURL%/smile.gif       | "smile" | --Smiley-- |
| <nop>:)           | %ATTACHURL%/smile.gif       | "smile" | --Smiley-- |

While putting it like that works (only! if the <!-- --Smiley-- --> is within the " "):

| <nop>:-)          | %ATTACHURL%/smile.gif       | "smile <!-- --Smiley-- -->" |
| <nop>:)           | %ATTACHURL%/smile.gif       | "smile <!-- --Smiley-- -->" |

So all this turned out be rather a low priority enhancement for robustness.

The reason why I am doing such "crazy" stuff is that I wanted to search for different icons based on added keywords which in my case are --Smiley--, --Customer-- and --Flag--. Generally I am using the smilies system also for shortcuts of other icons. Additionally I am looking for certain types of icons in HTML select boxes where I do not just want all icons together but only defined sets.

-- IngoKappler - 02 Jul 2009

It has to be Set SMILIESPLUGIN_TOPIC except if set in the plugin topic. This is the rule for all plugins.

I cannot see how your desired application has anything to do with robustness. It is a plain and simple feature enhancement request which should not be done without a feature proposal. Core code and default plugin enhancements follows our feature request process.

You never know what you may break for people by changing the format of the defining table. And I have the feeling that your solution with the comment in third column does the job just as well for you.

You should not set an enhancement request or even a bug report waiting for a particular developer to catch his attention unless there is a really good reason to. People like Sven and Crawford and myself already have a pretty long backlog of waiting for items. SmiliesPlugin is not a particular Crawford plugin. It is a default plugin and your request could be done by any of us as it would be a simple regex change. But again, it requires a feature proposal and a committed developer. It would be bad if we change the format and some people suddenly have trouble with the plugin.

-- KennethLavrsen - 02 Jul 2009

Kenneth, thanks for answering!

1. The task came into live before I identified the root cause, maybe I've been a bit too quick here, sorry.
2. Since it was there I changed it later to Enhancement and looked at the SmiliesPlugin to see what names are there. Crawford was the one that catched my eyes.
   1. I tried to avoid to not put anyone.
   2. Probably I should have looked at the enhancement system to figure out how it should work, next time, promised. ;)
3. I believe this is low priority as said above already and if you decide to not implement it, I really can live with it. It was not meant for me to achive somehting but to give feedback generally.
   1. I already found my solution. :)

For now I set it to "No action required". If I find a minute I will open a feature request so I play it correctly. Though I have even a more important enhancement suggestion for the SmiliesPlugin which I should ask for first.

-- IngoKappler - 03 Jul 2009