Item1671: Pathnames of Attachments inappropriate in default Plugins

Priority: Low
Current State: Closed
Released In: 1.0.6
Target Release: patch
Applies To: Engine
Component: Documentation, SlideShowPlugin, PrintSkin, Smilies
Branches:
Reported By: RaymondLutz
Waiting For:
Last Change By: KennethLavrsen
For data/System/SlideShowPlugin.txt we see attachments with bogus path names:

 
META:FILEATTACHMENT{name="startpres.gif" attr="h" 
comment="Start Presentation button" date="1037759933" 
path="C:\Data\MyTWiki\Plugins\SlideShowPlugin\pub\TWiki\SlideShowPlugin\startpres.gif" 
size="2065" user="ProjectContributor" version="1.1"}%

It looks like these are remnants from someone's local installation and need to be changes to simple file names like:

META:FILEATTACHMENT{name="startpres.gif" attr="h" 
comment="Start Presentation button" date="1237753321" 
path="startpres.gif" 
size="2065" user="ProjectContributor" version="1.1"}%

8 places in this file.


Also, in System/PrintSkin.txt

META:FILEATTACHMENT{name="screenshot.gif" attr="h" 
comment="" date="1090916727" 
path="C:\Data\Temp\screenshot.gif" 
size="4040" user="ProjectContributor" version="1.1"}%
META:FILEATTACHMENT{name="fullscreen.gif" attr="h" 
comment="" date="1090916872" 
path="C:\Data\Temp\fullscreen.gif" 
size="12968" user="ProjectContributor" version="1.2"}%


Also, in System/Smilies.txt

%META:FILEATTACHMENT{name="biggrin.gif" attr="h" 
comment="" date="1071216488" 
path="C:\Data\MyTWiki\Plugins\SmiliesPlugin\pub\TWiki\SmiliesPlugin\biggrin.gif" 
size="152" user="ProjectContributor" version="1.1"}%

20 places in this file.

NOTE

Per discussion on the email list, the pathnames in the topics are not used to find the files, only the final file name is used. Therefore, these longer path names are not a bug that should result in any attachments not being available.

-- RaymondLutz - 27 May 2009

also PlainSkin, WabiSabi, FileAttachment, and PreviewBackground

-- WillNorris - 31 May 2009

i think i got everything; however, i would appreciate if "someone" could double check. wink

-- WillNorris - 03 Jun 2009

I think this is OK. Waiting for release.

-- KennethLavrsen - 16 Jun 2009

ItemTemplate edit

Summary Pathnames of Attachments inappropriate in default Plugins
ReportedBy RaymondLutz
Codebase 1.0.5, 1.0.4
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Engine
Component Documentation, SlideShowPlugin, PrintSkin, Smilies
Priority Low
CurrentState Closed
WaitingFor
Checkins
TargetRelease patch
ReleasedIn 1.0.6
Topic revision: r9 - 22 Jun 2009, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License