You are here: Foswiki>Tasks Web>Item1580 (25 Apr 2011, GeorgeClark)Edit Attach

Item1580: AntiWikiSpamPlugin does not work with CommentPlugin

pencil
Priority: Normal
Current State: Closed
Released In: n/a
Target Release: n/a
Applies To: Extension
Component: AntiWikiSpamPlugin
Branches:
Reported By: ArthurClemens
Waiting For:
Last Change By: GeorgeClark
Unfortunately users can still post spam to the wiki with a comment box. It would be great if this plugin would work with comments as well.

Both plugins call beforeSaveHandler.

Instead it would be better design if any plugin in the save queue could write true/false in a method isAllowedToSave.

-- ArthurClemens - 06 May 2009

Just checked BlackListPlugin. It works fine with CommentPlugin.

-- KennethLavrsen - 06 May 2009

Yes, but my spammer changes IP literally every second (save and view). Blocking the IP has no effect. Blocking him from posting the site url would.

-- ArthurClemens - 06 May 2009

Adding an isAllowedToSave method won't fix this because the comment has actually not been applied to the topic text. Ordering of the plugin handlers is the solution. On IRC, mtempest suggested that the plugin could also ship a ZZZZZZZZAntiWikiSpamPlugin module to force it last in the list. That solves this without any core changes.

Another possible solution. Split the cfg{PluginOrder} variable to a "First;Last" list If the ;Last,Plugin list is present, then those plugins should be inserted into the list after the alphabetical ordering of plugins.

In this particular case, just adding CommentPlugin to the PluginOrder will work around this because the plugins are processed alphabetically after the fixed order plugins are processed.

-- GeorgeClark - 03 Jul 2010

ItemTemplate edit

Summary AntiWikiSpamPlugin does not work with CommentPlugin
ReportedBy ArthurClemens
Codebase
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Extension
Component AntiWikiSpamPlugin
Priority Normal
CurrentState Closed
WaitingFor
Checkins AntiWikiSpamPlugin:8cdaa57de3fd
TargetRelease n/a
ReleasedIn n/a
Topic revision: r6 - 25 Apr 2011, GeorgeClark - This page was cached on 27 Jun 2016 - 02:35.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License