cross
Foswiki General Assembly will be held on 12th December 2019, 1200 UTC on Freenode IRC channel #foswiki-association. See AgendaTenthGeneralAssembly

Item14765: Empty headings make section editing button edit the wrong section

pencil
Priority: Normal
Current State: Closed
Released In: n/a
Target Release: n/a
Applies To: Extension
Component: EditChapterPlugin
Branches: master
Reported By: ChristianKern
Waiting For:
Last Change By: ChristianKern
If a topic contains an empty heading, e.g.
---++

or

---+!!

then in all subsequent sections, the "edit section" buttons (which become visible on mouseover) will not edit their own section but the previous section.

Two empty headings make the buttons edit the pre-previous section. And so on (tested until level 5).

However: Two directly consecutive empty headings with no space in between,e.g.
---++
---++

(as opposed to

---++

---++
)

increase the offset only by one, not by two.

Edit: I was wrong in the first place: If the heading contains whitespace, the problem does not appear! I only appears with empty headings.

-- ChristianKern - 05 Oct 2018

My first reaction would be: why are there any empty headings...? Seems to be wrong in the first place.

Could you indicate which plugin this is that you are using? Thanks.

-- Main.MichaelDaum - 05 Oct 2018

Thanks for your quick response!

'> why are there any empty headings...? Seems to be wrong in the first place.
Well, in our medium-sized company's wiki, I found hundreds of these. Seems there's more than one user doing it wrong ...
Maybe a lot of these empty headings come from people using templates.

'> Could you indicate which plugin this is that you are using?
EditChapterPlugin (I've now inserted that into the form at the top of this page.)

-- ChristianKern - 05 Oct 2018

Maybe appending a ? to the regular expression part ([^\+#!].+?) in line 205 inside sub commonTagsHandler of Core.pm or to the (.+?) in line 400 might be part of the solution.

This is only an (long-time-since-)educated guess; I haven't programmed in Perl for ten years and I wasn't a great Perl programmer before that, so I don't really understand the whole module. => Someone else should check if my assumption/proposal is right.

-- ChristianKern - 05 Oct 2018

Does it solve the problem on your install?

-- MichaelDaum - 05 Oct 2018

I'm so sorry, I forgot to answer! No, it didn't help.

-- ChristianKern - 12 Nov 2019
 
Topic revision: r6 - 12 Nov 2019, ChristianKern - This page was cached on 03 Dec 2019 - 02:25.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy