Item14642: INCLUDE inconsistent between Release02x01 and master

pencil
Priority: Urgent
Current State: Closed
Released In: n/a
Target Release:
Applies To: Engine
Component: INCLUDE
Branches: master Item14288
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
With following test topic:
%INCLUDE{"MissingTopic, SimpleTopic" warn="should not warn"}%

%INCLUDE{"DenyToipc, SimpleTopic" warn="shuld not warn"}%

%INCLUDE{"DenyTopic" warn="WARNING deny topic"}%

%INCLUDE{"MissingTopic" warn="MISSING topic warning"}%

On Release02x01 it works as expected, warning the last 2 include statements.

On master, the 3rd INCLUDE warns "No permission to view DenyTopic", ignoring the custom warn message.

And a 2nd issue on master in the same area:

UserRegistration has the include:
%INCLUDE{"%USERSWEB%.%TOPIC%, %SYSTEMWEB%.Default%TOPIC%"}%

IF UserRegistration is set to DENY view, then the following error is generated:
warning
    Can't INCLUDE System.DefaultUserRegistration repeatedly, topic is already included. 

On Release02x01, the DefaultUserRegistration page is returned.

-- GeorgeClark - 05 Mar 2018

These both are regressions
  • Item11548 - warn only works for missing topics, and
  • Item14077 - claims topic already included.

-- GeorgeClark - 05 Mar 2018

The commit for e96caf53ad952a3cac9350f7f5108f1c1c4823f2 was listed in the log, but is not applied to the file. Somehow it got reverted, but the revert doesn't show up in the git blame for the file.

-- GeorgeClark - 05 Mar 2018

 
Topic revision: r2 - 13 Jun 2018, GeorgeClark - This page was cached on 23 Oct 2018 - 10:07.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy