You are here: Foswiki>Tasks Web>Item14592 (06 Feb 2018, GeorgeClark)Edit Attach

Item14592: Extra unescaped double quotes in MAKETEXT macro resulting in truncated string

pencil
Priority: Normal
Current State: Closed
Released In: n/a
Target Release: n/a
Applies To: Engine
Component: BulkResetPassword, PasswordReset
Branches: Item14506 master Item14288 Item14380 Item14537
Reported By: RaulFRodriguez
Waiting For:
Last Change By: GeorgeClark
I was checking the new strings that require translation in the Foswiki Distribution master used for the current release candidate, and I came across one that says:

*This text will be sent to users in their 

(that's all)

so I checked the source where this string comes from, which are these two files and line numbers:

the macro contents there are delimited by double quotes ", but the text itself contains double quotes around the "reset" word:

%MAKETEXT{"*This text will be sent to users in their "reset" e-mail.* The login name and password will be filled in automatically."}%

which I believe should be escaped or just removed to avoid truncation of the string

I have left this string untranslated, as I can't translate anything there unless this is corrected at the code level (I don't have currently a working Foswiki development environment and it is difficult for me to correct that myself)

I am usure about how I should rate the urgency of this bug, so I set it to "Normal". I don't know if the untranslated text contained in the macro will display at all or if that will confuse the macro execution and result in an unterminated string or worse a Perl error, in these cases, it should probably be set to a higher priority.

Feel free to change that urgency level and any other details. In any case, this is blocking the translation process in all the languages for that string and that's currently the only string remaining to be translated in French language in Master at http://translate.foswiki.org/translate/foswiki/distribution-master/fr/?type=untranslated

-- RaulFRodriguez - 09 Jan 2018

Fixed in master. Note that master is the upcoming 2.2 feature release. 2.1.5 is in the Release02x01 branch.

Closing task. Fixed, but these strings were not in released code, no need to document.

-- Main.GeorgeClark - 10 Jan 2018 - 04:04

OK, Thanks George!

-- RaulFRodriguez - 10 Jan 2018
 
Topic revision: r9 - 06 Feb 2018, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy