Item14517: button css depends on PatternSkin
Current State: Confirmed
Released In: n/a
The "Edit" button rendered below a table is depending on css only available in PatternSkin
. Looks odd on NatSkin
The same button in EditTablePlugin
looks just fine.
- 13 Oct 2017
I think I found the source of the problem (and possible fix). Comparing the rendered styles using NatSkin and PatternSkin, I see that the display of the icon requires
proper back-ground positioning (because it's using a single composite icon for all buttons). Something in NatSkin css is over-riding the positioning set by EditRowPlugin
style sheet. I found I could fix the display issue by adding
to the background-position definition (this is on line 83 of erp.uncompressed.css
). The is already applied to all the background-image definitions. I suspect it should be added to all of the background-position definitions in that style sheet.
I also found that in PatternSkin, a very specific padding (see below) was defined for all
class icons. I suspect that this is in PatternSkin style-sheets and assumed for EditRowPlugin
. It should perhaps be included directly in EditRowPlugin
stylesheet for better skin-compatibility.
Being as I had a custom style-sheet already set up to over-ride various default stylings, for a short-term fix I added the following to that style sheet:
background-position: 0 -16px !important;
padding: 3px 9.799999999999999px 3px 9.799999999999999px !important;
- 06 Nov 2017