cross
New Foswiki release 2.1.6 is available with important security fixes.
Sourceforge foswiki email lists being discontinued. Subscribe to the new Foswiki announce and discuss lists at MailingLists
You are here: Foswiki>Tasks Web>Item14493 (31 Jan 2018, GeorgeClark)Edit Attach

Item14493: ICONURL and ICONURLPATH do not work with skin based ICONs.

pencil
Priority: Enhancement
Current State: Confirmed
Released In: n/a
Target Release: n/a
Applies To: Engine
Component: FamFamFamContrib, FoswikiTemplates
Branches: master Item14288 Item14454 Item14380 Item14537
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
ICON macro renders using templates provided by the icons.tmpl template. However the ICONURL and ICONURLPATH macros expect to find icons attached to DocumentGraphics. This means that template/skin based overrides of icons get ignored by macros referencing ICONURL / ICONURLPATH. (eg. TwistyPlugin)

See the discussion: irc logs

The icons.tmpl and the ICON.pm module needs some redesign so that ICON, ICONURL and ICONURLPATH are all consistently expanded.

Note also that icons.tmpl is shipped as part of FamFamFamContrib, but is used the core ICON.pm macro. This breaks the boundaries between core and extensions.

-- GeorgeClark - 20 Sep 2017

And... icons.tmpl (from FamFamFamContrib) overrides the icon:image template defined in foswiki.tmpl. It "fixes" a template that mixed single and double quotes in the html. The code in Foswiki::Render::IconImage depends on the first detected quote to fix-up the single or double quotes. Mixed quotes in the base template breaks the quote= option of the ICON macro.

There is also an apparently unused icon:image_singlequote template defined in foswiki.tmpl.

-- GeorgeClark - 27 Sep 2017
 
Topic revision: r8 - 31 Jan 2018, GeorgeClark - This page was cached on 21 Sep 2018 - 14:28.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy