Item14454: Bundle JsViews as an option with JsRender

pencil
Priority: Enhancement
Current State: Waiting for Release
Released In: 2.1.7
Target Release: patch
Applies To: Extension
Component: JQueryPlugin
Branches: Item14454 master Item14288 Item14380 Item14537 Release02x01
Reported By: ChrisHoefler
Waiting For:
Last Change By: MichaelDaum
Can you please consider bundling the JsViews framework with JQueryPlugin. JsViews extends the functionality of JsRender by providing two-way data-dependent linking to JsRender templates.

I have created a JQuery plugin stub that I have bundled up and attached. I did not create it as a standalone plugin because the version has to match the version of JsRender. So when JsRender is updated, the JsViews components also have to be updated to avoid breakage. There is no other clean way to support both plain JsRender and JsViews. A %NOPJQREQUIRE{"jsviews"}% will automatically pull in the JsRender dependency. Since this is a relatively minor and unobtrusive change, I'm hoping it can be included with JQueryPlugin.

What do you think? Please advise.

-- ChrisHoefler - 01 Aug 2017

See also AddJsViews

I am all for it, i.e. given your newly created JsonSQLPlugin smile

-- MichaelDaum - 02 Aug 2017

Ok. I will format it for a push into a foswiki/distro/JQueryPlugin branch.

-- ChrisHoefler - 02 Aug 2017

Let's put it here:

  • pub/System/JQueryPlugin/plugins/view/...
  • lib/Foswiki/Plugins/JQueryPlugin/VIEW.pm

so that we can do a %JQREQUIRE{"view"}% in addition to the current %JQREQUIRE{"render"}%.

-- MichaelDaum - 02 Aug 2017

Done. Pull request, https://github.com/foswiki/distro/pull/17

I can merge, but thought somebody should review it first.

-- ChrisHoefler - 02 Aug 2017

Seen that. First of all, we have to wait at least 14 days for AddJsViews to be auto-accepted. Until then we give people the occasion to veto. Looking at your checkin, there is lots of tests and demos part of the official jsview release. Could you please reduce it to the absolute minimum required to run jsviews? Finally, we have to keep jsrender and jsview in sync wrt their upstream version.

-- MichaelDaum - 02 Aug 2017

Ah, I see. Thanks for the clarification. I admit I was a bit unclear on how the steps of ReleaseProcess line up with GitRepository.

<snipped questions - I think I understand the intended process now>

-- ChrisHoefler - 03 Aug 2017

I will trim down the plugin code to just the two libraries needed. The version is currently in sync with the version of Render in master, but they are both behind the upstream version. Should we update them?

-- ChrisHoefler - 03 Aug 2017

Pushed trimmed plugin code to Item14454 branch. Will update Render and View to the latest upstream if that is desired.

-- ChrisHoefler - 03 Aug 2017

Proposal accepted

-- MichaelDaum - 18 Sep 2017

I have the patch ready to go. Just need to do a quick review and then I'll submit a pull request.

Did we decide whether the versions should be upgraded to the latest upstream? I didn't do that, but I can.

-- ChrisHoefler - 23 Sep 2017

Merged to core.

-- ChrisHoefler - 15 Dec 2017

Releasing earlier.

-- MichaelDaum - 12 Jun 2018
 
Topic revision: r22 - 13 Jun 2018, MichaelDaum - This page was cached on 13 Nov 2018 - 13:26.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy