cross
Foswiki General Assembly will be held on 28th November 2019, 1200 UTC on Freenode IRC channel #foswiki-association. See AgendaTenthGeneralAssembly

Item14454: Bundle JsViews as an option with JsRender

pencil
Priority: Enhancement
Current State: Waiting for Release
Released In: 2.1.7
Target Release: patch
Applies To: Extension
Component: JQueryPlugin
Branches: Item14454 master Item14288 Item14380 Item14537 Release02x01
Reported By: ChrisHoefler
Waiting For:
Last Change By: MichaelDaum
Can you please consider bundling the JsViews framework with JQueryPlugin. JsViews extends the functionality of JsRender by providing two-way data-dependent linking to JsRender templates.

I have created a JQuery plugin stub that I have bundled up and attached. I did not create it as a standalone plugin because the version has to match the version of JsRender. So when JsRender is updated, the JsViews components also have to be updated to avoid breakage. There is no other clean way to support both plain JsRender and JsViews. A %NOPJQREQUIRE{"jsviews"}% will automatically pull in the JsRender dependency. Since this is a relatively minor and unobtrusive change, I'm hoping it can be included with JQueryPlugin.

What do you think? Please advise.

-- ChrisHoefler - 01 Aug 2017

See also AddJsViews

I am all for it, i.e. given your newly created JsonSQLPlugin smile

-- MichaelDaum - 02 Aug 2017

Ok. I will format it for a push into a foswiki/distro/JQueryPlugin branch.

-- ChrisHoefler - 02 Aug 2017

Let's put it here:

  • pub/System/JQueryPlugin/plugins/view/...
  • lib/Foswiki/Plugins/JQueryPlugin/VIEW.pm

so that we can do a %JQREQUIRE{"view"}% in addition to the current %JQREQUIRE{"render"}%.

-- MichaelDaum - 02 Aug 2017

Done. Pull request, https://github.com/foswiki/distro/pull/17

I can merge, but thought somebody should review it first.

-- ChrisHoefler - 02 Aug 2017

Seen that. First of all, we have to wait at least 14 days for AddJsViews to be auto-accepted. Until then we give people the occasion to veto. Looking at your checkin, there is lots of tests and demos part of the official jsview release. Could you please reduce it to the absolute minimum required to run jsviews? Finally, we have to keep jsrender and jsview in sync wrt their upstream version.

-- MichaelDaum - 02 Aug 2017

Ah, I see. Thanks for the clarification. I admit I was a bit unclear on how the steps of ReleaseProcess line up with GitRepository.

<snipped questions - I think I understand the intended process now>

-- ChrisHoefler - 03 Aug 2017

I will trim down the plugin code to just the two libraries needed. The version is currently in sync with the version of Render in master, but they are both behind the upstream version. Should we update them?

-- ChrisHoefler - 03 Aug 2017

Pushed trimmed plugin code to Item14454 branch. Will update Render and View to the latest upstream if that is desired.

-- ChrisHoefler - 03 Aug 2017

Proposal accepted

-- MichaelDaum - 18 Sep 2017

I have the patch ready to go. Just need to do a quick review and then I'll submit a pull request.

Did we decide whether the versions should be upgraded to the latest upstream? I didn't do that, but I can.

-- ChrisHoefler - 23 Sep 2017

Merged to core.

-- ChrisHoefler - 15 Dec 2017

Releasing earlier.

-- MichaelDaum - 12 Jun 2018
 

ItemTemplate edit

Summary Bundle JsViews as an option with JsRender
ReportedBy ChrisHoefler
Codebase trunk
SVN Range
AppliesTo Extension
Component JQueryPlugin
Priority Enhancement
CurrentState Waiting for Release
WaitingFor
Checkins distro:23fe3294eb36 distro:611e981a276a distro:931187e792b2 distro:b27be897ca72 distro:cfb113cf7fef distro:562e752540e7 distro:27074b159f43 distro:7f37405c9cac distro:16dc8dbcd75e distro:3d86c6ac2311 distro:63aab4faec43 distro:d52101342133 distro:e5e8348d5dd2 distro:cfd0cb00c0ba distro:ea52bde57216 distro:f6afb02af39c distro:c91879499766 distro:39a9287b4064 distro:5303b9a5def8 distro:b58f875ea852 distro:4fd7b438800f
TargetRelease patch
ReleasedIn 2.1.7
CheckinsOnBranches Item14454 master Item14288 Item14380 Item14537 Release02x01
trunkCheckins
masterCheckins distro:63aab4faec43 distro:d52101342133 distro:e5e8348d5dd2 distro:cfd0cb00c0ba distro:ea52bde57216 distro:4fd7b438800f distro:f6afb02af39c distro:c91879499766 distro:39a9287b4064 distro:5303b9a5def8 distro:b58f875ea852
ItemBranchCheckins distro:23fe3294eb36 distro:611e981a276a distro:931187e792b2 distro:b27be897ca72 distro:cfb113cf7fef distro:562e752540e7 distro:27074b159f43 distro:7f37405c9cac distro:16dc8dbcd75e distro:3d86c6ac2311 distro:63aab4faec43 distro:d52101342133 distro:e5e8348d5dd2 distro:cfd0cb00c0ba distro:ea52bde57216 distro:4fd7b438800f
Release02x01Checkins distro:f6afb02af39c distro:c91879499766 distro:39a9287b4064 distro:5303b9a5def8 distro:b58f875ea852
Release02x00Checkins
Release01x01Checkins
Topic attachments
I Attachment Action Size Date Who Comment
JQueryViews.tar.gzgz JQueryViews.tar.gz manage 9 MB 01 Aug 2017 - 16:21 ChrisHoefler  
Topic revision: r24 - 10 May 2019, MichaelDaum - This page was cached on 19 Nov 2019 - 20:59.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy