You are here: Foswiki>Tasks Web>Item14297 (12 Feb 2019, MichaelDaum)Edit Attach

Item14297: NatSkin places script zone at end of page, potentially breaking inline scripts

pencil
Priority: Normal
Current State: No Action Required
Released In: n/a
Target Release: n/a
Applies To: Extension
Component: NatSkin
Branches:
Reported By: PaulMerchantJr
Waiting For:
Last Change By: MichaelDaum
The NatSkin templates released on Jan. 23 relocates the rendering of the script zone from the page header to the end of the page body. I suspect this was done to improve the page loading experience, but it breaks any inline Javascript that assumes libraries have already been loaded. This includes some pages in Foswiki plugins such as UpdatePlugin. I can see this being a desirable trait, but would it be possible for the skin to include an option to allow users to select whether they want this behavior or the original behavior, and to leave the default on the original behavior? Unless I missed it, there's no warning about this change in the update notes, and in a site with thousands of pages it's not practical to adapt every page to this change.

-- PaulMerchantJr

This has been reverted not to break inline scripts.

-- MichaelDaum - 12 Feb 2019
 

ItemTemplate edit

Summary NatSkin places script zone at end of page, potentially breaking inline scripts
ReportedBy PaulMerchantJr
Codebase 2.1.3 beta1, 2.1.2
SVN Range
AppliesTo Extension
Component NatSkin
Priority Normal
CurrentState No Action Required
WaitingFor
Checkins
TargetRelease n/a
ReleasedIn n/a
CheckinsOnBranches
trunkCheckins
masterCheckins
ItemBranchCheckins
Release02x01Checkins
Release02x00Checkins
Release01x01Checkins
Topic revision: r4 - 12 Feb 2019, MichaelDaum
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy