You are here: Foswiki>Tasks Web>Item13831 (31 Jan 2018, MichaelDaum)Edit Attach

Item13831: JS error in System.LanguageSelector

pencil
Priority: Normal
Current State: Closed
Released In: 2.1.3
Target Release: patch
Applies To: Engine
Component: Documentation, I18N, JavaScript
Branches: master Item14033 Item13897 Release02x01 Item14380 Item14537
Reported By: JozefMojzis
Waiting For:
Last Change By: MichaelDaum

Repo

  • Enable UI languages
  • go to LanguageSelector
  • try change a language
  • the language doesn't change
  • and in the console.log is the following error
TypeError: document.changeLanguage.submit is not a function. (In 'document.changeLanguage.submit()', 'document.changeLanguage.submit' is undefined)
onchangeLanguageSelector:194

Note:
  • changing languages in other topics doesn't affected (AFIK)
  • changing language with disabled javascript works in the LanguageSelector topic.

Also, the topic parent is TimeSpecifications - probably wrong, the language selector isn't time-related thingy..

-- JozefMojzis - 21 Oct 2015

I think that the issue is the language selector can only be created once on a page. If it's already in the top bar, a 2nd selector isn't needed. I think we can just disable the "demonstration" include on the page, and treat it as documentation only.

-- GeorgeClark - 12 Apr 2016

There definitely is room for optimization.

-- MichaelDaum - 12 Apr 2016

The latest version breaks the HTML validation tests, and fails to render the selection list. Need to defer expansion of the include. Reopening.

-- Main.GeorgeClark - 21 Apr 2016 - 02:14

This error still persists in 2.1.3. Fixes have not been merged to the release branch.

-- MichaelDaum - 16 Jan 2017

Cannot merge from master -> Release. Need to cherry pick. Fixes committed into the wrong branch initially.

-- GeorgeClark - 16 Jan 2017
 
Topic revision: r16 - 31 Jan 2018, MichaelDaum
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy