You are here: Foswiki>Tasks Web>Item13726 (10 Oct 2015, GeorgeClark)Edit Attach

Item13726: SmiliesPlugin icon files have all changed file name and that causes broken links for legacy sites.

pencil
Priority: Normal
Current State: Closed
Released In: 2.0.2
Target Release: patch
Applies To: Extension
Component: SmiliesPlugin
Branches: master
Reported By: KennethLavrsen
Waiting For:
Last Change By: GeorgeClark
The enhancement to the SmiliesPlugin that adds more and nice icons also resulted in all the filenames to be altered.

So smile.gif became emoticon-0100-smile.gif

This has no negative impact when people use the plugin as intended like smile

But normal users know nothing about intended use and they copy text incl smily icons from their browser in normal view mode and paste it into another window in edit mode.

The result is raw HTML img tags that point to the smile.gif file with the entire URL. It always works fine and all are happy.

When you upgrade the SmiliesPlugin (or Foswiki 1.1.9 to 2.0.X) all these silly links points to nowhere

After a talk on IRC George and I agreed the best way to mitigate this is to attach the old icon images to the SmiliesPlugin topic

BUT BUT

NOT make them in any way available through the plugin. Ie. all the smilies will result in the new files. And the old files will not be documented on the topic.

They will just be there attached for compatibility so the manually copied links will continue to work and topics will not be broken when viewed.

As I write this George is ready with the checkin.

-- KennethLavrsen - 17 Sep 2015

Also is possible to fix at the web-server level - rewrite the old image urls to the new ones - for examples an special include for the apache-config, or such.

OFC, attaching the old images is the easiest way at the cost of duplicate images. Maybe enough symlinks old_name -> new_name, but i'm not sure about the windows...

-- JozefMojzis - 17 Sep 2015
 

ItemTemplate edit

Summary SmiliesPlugin icon files have all changed file name and that causes broken links for legacy sites.
ReportedBy KennethLavrsen
Codebase 2.0.1
SVN Range
AppliesTo Extension
Component SmiliesPlugin
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:a5a92c835b6d
TargetRelease patch
ReleasedIn 2.0.2
CheckinsOnBranches master
trunkCheckins
masterCheckins distro:a5a92c835b6d
ItemBranchCheckins
Release01x01Checkins
Topic revision: r6 - 10 Oct 2015, GeorgeClark - This page was cached on 28 Jun 2016 - 00:14.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License