You are here: Foswiki>Tasks Web>Item13491 (02 Jul 2015, GeorgeClark)Edit Attach

Item13491: Configure extension installer can crash if no plugins in the extension.

pencil
Priority: Normal
Current State: Closed
Released In: 2.0.0
Target Release: n/a
Applies To: Engine
Component: Configure
Branches: master
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
-- GeorgeClark - 01 Jul 2015

Fails with:
couldn't parse tools/configure : Can't use an undefined value as a HASH reference at /var/www/data/Foswiki-2.0.0-RC1/lib/Foswiki/Configure/Package.pm line 501.
couldn't do tools/configure: Inappropriate ioctl for device at /var/www/data/Foswiki-2.0.0-RC1/tools/extender.pl line 228.
couldn't run tools/configure at /var/www/data/Foswiki-2.0.0-RC1/tools/extender.pl line 229.

-- GeorgeClark - 01 Jul 2015

Patch:
diff --git a/core/lib/Foswiki/Configure/Package.pm b/core/lib/Foswiki/Configure/Package.pm
index f2926e8..e11603b 100644
--- a/core/lib/Foswiki/Configure/Package.pm
+++ b/core/lib/Foswiki/Configure/Package.pm
@@ -498,7 +498,7 @@ HERE
         $reporter->WARN(
 "Don't forget to save your configuration to complete installation of "
               . join( ', ', keys %plugins ) )
-          if ( scalar( keys %{ $reporter->changes() } ) );
+          if ( $reporter->changes() && scalar( keys %{ $reporter->changes() } ) );
     }
 
     $reporter->NOTE( "> Installation "

-- GeorgeClark - 01 Jul 2015
 

ItemTemplate edit

Summary Configure extension installer can crash if no plugins in the extension.
ReportedBy GeorgeClark
Codebase 2.0.0 RC1, 1.2.0 beta2, 1.2.0 beta1, trunk
SVN Range
AppliesTo Engine
Component Configure
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:165f59a1780f
TargetRelease n/a
ReleasedIn 2.0.0
CheckinsOnBranches master
trunkCheckins
masterCheckins distro:165f59a1780f
ItemBranchCheckins
Release01x01Checkins
Topic revision: r3 - 02 Jul 2015, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy