Item13479: Store is interpreting %TOPICINFO in textfile attachments

pencil
Priority: Normal
Current State: Confirmed
Released In: n/a
Target Release:
Applies To: Extension
Component: RCSStoreContrib
Branches:
Reported By: GeorgeClark
Waiting For:
Last Change By: CrawfordCurrie
"Attach" an existing "TestTöpic.txt" file to use for simple attachment testing. The "TestTöpic.txt" file happens to contain a TOPICINFO, but it's an attachment so it should be "just data".

%META:TOPICINFO{author="BaseUserMapping_333" comment="reprev" date="1435428215" format="1.1" reprev="7" version="7"}%

Update the attachment. rlog shows the correct versions.

RCS file: ./TestTöpic.txt,v
Working file: ./TestTöpic.txt
head: 1.2
branch:
locks: strict
access list:
symbolic names:
keyword substitution: o
total revisions: 2;     selected revisions: 2
description:
none
----------------------------
revision 1.2
date: 2015/06/27 18:07:21;  author: BaseUserMapping_333;  state: Exp;  lines: +8 -2
estTöpic.tx
----------------------------
revision 1.1
date: 2015/06/27 18:07:21;  author: BaseUserMapping_999;  state: Exp;
autosave
=============================================================================

However viewing the attachment history shows 7 revisions:

Version history of TestTöpic.txt

Version history
Version Action Date Who Comment
2 view 27 Jun 2015 - 18:07 AdminUser  
2 view 27 Jun 2015 - 18:07 AdminUser  
2 view 27 Jun 2015 - 18:07 AdminUser  
2 view 27 Jun 2015 - 18:07 AdminUser  
2 view 27 Jun 2015 - 18:07 AdminUser  
2 view 27 Jun 2015 - 18:07 AdminUser estTöpic.tx
1 view 27 Jun 2015 - 18:07 UnknownUser autosave

Crawford. Marking this one for you to review. I think it's very minor and can be left in the backlog.

-- GeorgeClark - 28 Jun 2015

It's a bug in the RCS stores. It happens because the iterator over the version history is based on 1..latest, and latest is obtained using the topic-specific shortcut that looks into the .txt file for the TOPICINFO.

I'm sure it wouldn't be too hard to fix.

-- Main.CrawfordCurrie - 29 Jun 2015 - 17:01
 

ItemTemplate edit

Summary Store is interpreting %TOPICINFO in textfile attachments
ReportedBy GeorgeClark
Codebase 1.2.0 beta2, trunk
SVN Range
AppliesTo Extension
Component RCSStoreContrib
Priority Normal
CurrentState Confirmed
WaitingFor
Checkins
ReleasedIn n/a
CheckinsOnBranches
trunkCheckins
masterCheckins
ItemBranchCheckins
Release01x01Checkins
Topic revision: r2 - 29 Jun 2015, CrawfordCurrie
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy