You are here: Foswiki>Tasks Web>Item13431 (05 Jul 2015, GeorgeClark)Edit Attach

Item13431: Eliminate the auto redirect from the change language template.

pencil
Priority: Urgent
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Engine
Component:
Branches: master
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
The oops message doesn't appear to render the "script" definition:

 %<nop>TMPL:DEF{"script"}%<meta http-equiv="refresh" content="0;url=%SCRIPTURL{view}%/%WEB%/%TOPIC%?%QUERYPARAMS{encoding="safe" separator=";"}%" />%TMPL:END%

Not quite sure how this is supposed to be rendered into the page. But it works fine on 1.1.9,

-- GeorgeClark - 24 May 2015

Actually, this behaviour is deprecated because it can be disorienting to some users. See http://www.w3.org/TR/WCAG10-HTML-TECHS/#meta-element I've got a fix that will expand the tag, no idea why it's needed, but probably better to just remove this behaviour.

diff --git a/core/templates/oopslanguagechanged.tmpl b/core/templates/oopslanguagechanged.tmpl
index 2c2ce7f..5f48cfc 100644
--- a/core/templates/oopslanguagechanged.tmpl
+++ b/core/templates/oopslanguagechanged.tmpl
@@ -13,4 +13,4 @@
 %TMPL:DEF{"webaction"}% *%MAKETEXT{"Attention"}%* %TMPL:END%
 
 %TMPL:DEF{"message"}%%SESSION_VARIABLE{"LANGUAGE" set="%<nop>URLPARAM{language}%"}%
-%MAKETEXT{"Your language will be changed to [_1] from the next screen. You will be redirected to there right now. If you aren't, ~[~[[_2]~]~[click to proceed~]~]." args="*%SESSION_VARIABLE{LANGUAGE}%*, %SCRIPTURLPATH{"view"}%/%WEB%/%TOPIC%"}%%TMPL:END%
\ No newline at end of file
+%MAKETEXT{"Your language will be changed to [_1] from the next screen. You will be redirected to there right now. If you aren't, ~[~[[_2]~]~[click to proceed~]~]." args="*%SESSION_VARIABLE{LANGUAGE}%*, %SCRIPTURLPATH{"view"}%/%WEB%/%TOPIC%"}%%TMPL:P{"script"}%%TMPL:END%

-- GeorgeClark - 31 May 2015
 

ItemTemplate edit

Summary Eliminate the auto redirect from the change language template.
ReportedBy GeorgeClark
Codebase 1.2.0 beta1, trunk
SVN Range
AppliesTo Engine
Component
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:b2c674066e55
TargetRelease major
ReleasedIn 2.0.0
CheckinsOnBranches master
trunkCheckins
masterCheckins distro:b2c674066e55
ItemBranchCheckins
Release01x01Checkins
Topic revision: r4 - 05 Jul 2015, GeorgeClark - This page was cached on 04 Dec 2016 - 23:50.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License