Item13365: forcenewrevision checkbox is not working

pencil
Priority: Urgent
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Extension
Component: NatEditPlugin, PatternSkin
Branches: master
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
The forcenewrevision checkbox is not working. It appears that it is submitted 3 times in the POST, so it's a multi_param, and ends up not being active.

Fails on both NatEdit, TinyMCE and the WikiText editor. With NatEdit and TinyMCE, forcenewrevision appears 3 times. With wikitext editor, only twice. But still a NOP. Here are the POST parameters from a wikitext edit session.

action   
action_save   Save
cmd   
cover   
forcenewrevision   on
forcenewrevision   
formtemplate   
newtopic   
nowysiwyg   1
originalrev   2_1428633760
redirectto   
rev   
sig   -- Main.JoeUser - 10 Apr 2015
skin   pattern
templatetopic   

-- GeorgeClark - 10 Apr 2015

Looking at the page source, for a NatEdit session, it's there in 3 places.
<input type="hidden" name="forcenewrevision" value="" />
...
<li class="natEditForceNewRevision"><label for="forcenewrevision"><input type="checkbox" title="Creates a new topic revision when saving" id="forcenewrevision" name="forcenewrevision"  />Force new revision</label></li>
....
<input type="hidden" name="forcenewrevision" value="" /> 

-- GeorgeClark - 10 Apr 2015

Wow this was buggy for a long time in both natedit as well as plain pattern.

-- MichaelDaum - 10 Apr 2015
 

ItemTemplate edit

Summary forcenewrevision checkbox is not working
ReportedBy GeorgeClark
Codebase 1.2.0 beta1
SVN Range
AppliesTo Extension
Component NatEditPlugin, PatternSkin
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:fde394dbc057
TargetRelease major
ReleasedIn 2.0.0
CheckinsOnBranches master
trunkCheckins
masterCheckins distro:fde394dbc057
ItemBranchCheckins
Release01x01Checkins
Topic revision: r3 - 05 Jul 2015, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy