You are here: Foswiki>Tasks Web>Item13318 (05 Jul 2015, GeorgeClark)Edit Attach

Item13318: Shipped topics are missing attachment metadata, and TOPICINFO

pencil
Priority: Normal
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Extension
Component: FamFamFamContrib
Branches: master
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
Some of the Icon sets don't have any attachment meta in their topics.

-- GeorgeClark - 21 Mar 2015

Also several topic didn't contain TOPICINFO headers.

-- GeorgeClark - 21 Mar 2015

Expanding this to cover any default topics. Finding more with out-of-sync metadata

-- GeorgeClark - 21 Mar 2015

MichaelDaum... could you please review. Thanks.

  • DefaultUserRegistration/validate.js doesn't have compressed and gzipped forms in the manifest.
  • UserRegistration/js.js also missing compressed / gzipped forms

I think that js.js is not used, and validate.js probably ought to be moved to the JavascriptFiles topic.

-- GeorgeClark - 23 Mar 2015

Yes, adding proper TOPICINFO is a Good Thing To Do. This wasn't the case previously as we worked under the impression that some day TOPICINFO should be removed from the TXT file. This actually is a very very old discussion that didn't lead to anywhere up to now. During the course of 1.2.0 it then turned out that not having any TOPICINFO forces the store code into a slow code path that severely impacts overall performance of the system. So any topic not having proper TOPICINFO is considered "dirty" and as such in need of a forced save to repair the topic. Which means: any topic without a TOPICINFO that is about to be saved by a user will actually be saved twice: (1) a repairment save to bring back proper TOPICINFO and (2) the actual save done by the user. This is of course a bad thing to happen and should remain an exception.

So shipping all topics of the distro including TOPICINFO is absolutely the right thign to do. As well as is the case for any other extension being built. There are still a lot of extension that ship "dirty" TXT files. But that's probably worth another task.

Wrt piling up js files at System.JavascriptFiles: Let's better keep those js files close to where they are actually, unless they are of more general use somewhere else. The mentioned js files are probably closely related to the registration app. So better keep them there in that case.

-- MichaelDaum - 23 Mar 2015
 
Topic revision: r8 - 05 Jul 2015, GeorgeClark - This page was cached on 25 Jun 2016 - 17:55.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License