You are here: Foswiki>Tasks Web>Item13247 (08 Jul 2015, MichaelDaum)Edit Attach

Item13247: Some VarXXX topics do not consistently link to other entries in Macros

pencil
Priority: Normal
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Engine
Component: JQueryPlugin, TwistyPlugin
Branches: master
Reported By: JulianLevens
Waiting For:
Last Change By: MichaelDaum
In the System.Macros topic the usual structure is to have a
  • Related: VarXXX, XXX bullet point listing anchors within Macros and links to other topics

For Example:

ATTACHURLPATH -- path of the attachment URL of the current topic

Shorthand for PUBURLPATH with path set to the current topic. Otherwise supports all the same parameters as PUBURLPATH.

Note that the links are shown as the names of the relevant MACRO only not VarMACRO. In addition these are links to the anchor within Macros (doesn't work that way when included into this topic check System.Macros itself) and the link is therefore done by the browser and fast. Therefore VarMACRO would not be a logical choice. However, FileAttachments is not a VarXXX topic and is a link to that actual topic which is logical.

I noticed that a number of VarXXX topics are not consistent with this approach

Furthermore I discovered that the standard link is within the VarXXX topic is constructed as follows:
   * Related: [[%IF{"'%INCLUDINGTOPIC%'='Macros'" then="#"}%VarATTACHURL][ATTACHURL]]
and this has sometimes been missed in these Related: entries as well.

EITHER
  • VarXXX is a related link to the topic itself not the anchor with Macros
OR
  • VarXXX is a link to the anchor within macros but is shown as VarXXX and not XXX to the user

The relevant topics that need changing are:

This set (all from TwistyPlugin) refers to each other (and unnecessarily self) as a anchor link but shows this as VarXXX and not XXX. Only VarTWISTY needed changing to correct this.

This set (all from JQueryPlugin) relates to VarXXX entries as topic links and not an XXX anchor

I've noticed this on Trunk and VarENDCOLOR as far back as 1.0.8

-- JulianLevens - 03 Feb 2015

 

ItemTemplate edit

Summary Some VarXXX topics do not consistently link to other entries in Macros
ReportedBy JulianLevens
Codebase trunk
SVN Range
AppliesTo Engine
Component JQueryPlugin, TwistyPlugin
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:268674d41ba6
TargetRelease major
ReleasedIn 2.0.0
CheckinsOnBranches master
trunkCheckins
masterCheckins distro:268674d41ba6
ItemBranchCheckins
Release01x01Checkins
Topic revision: r5 - 08 Jul 2015, MichaelDaum - This page was cached on 27 May 2016 - 12:32.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License