Foswiki on GitHub is open for business! Next release meeting: Monday September 15, 1300Z

Item1299: Moving a web or single topic does not corrently update links in topics

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Urgent Closed Engine    
Moving a web does not cause links that should be updated to be updated correctly

It is too much to try and give a total test case.

You need to define a web and put a subweb under this web. From the WebHome of this web make some links to topics in the web and in the sub web.

Also make some links to other webs.

Use double square bracket syntax type links

Now move the web around to below another web and back as a root web. Note as you move it that links do not get correctly updated.

This used to work and has been goofed in recent time.

-- KennethLavrsen - 15 Mar 2009

It is not just when moving webs.

Moving / renaming a simple topic does not cause any re-linking to happen.

When you rename the correct topics are listed but in reality none of the topics that should be updated are touched resulting in all links to be broken that points to the renamed topic.

-- KennethLavrsen - 15 Mar 2009

I did a binary search of recent SVN checkins and it is Crawford's Foswikirev:3068 that has caused all this.

-- KennethLavrsen - 15 Mar 2009

In fact, the unit tests are showing exactly that. Now that's I've cleared them from all errors introduced by MichaelDaum's fix for statistics, we can clearly see the errors on rename.

Unit test is a bit hard to read, but they seem ok, and as the manual tests are also failing, I guess there is a bug in Crawford's code smile

Indeed, =split( '.' = .. but split takes a regex as argument, therefore it was splitting on the first character smile

-- OlivierRaginel - 15 Mar 2009

Apologies, I found and corrected this on trunk but didn't transfer the fix to Release01x00. Thanks Babar for cleaning up after me.

-- CrawfordCurrie - 16 Mar 2009

ItemTemplate edit

Summary Moving a web or single topic does not corrently update links in topics
ReportedBy KennethLavrsen
Codebase trunk
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Engine
Component
Priority Urgent
CurrentState Closed
WaitingFor
Checkins Foswikirev:3123
TargetRelease patch
ReleasedIn 1.0.4
Topic revision: r6 - 19 Mar 2009, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License