You are here: Foswiki>Tasks Web>Item12895 (29 May 2014, GeorgeClark)Edit Attach

Item12895: cover=print and skin=print,pattern should give identical results.

pencil
Priority: Normal
Current State: Closed
Released In: 1.2.0
Target Release: n/a
Applies To: Engine
Component: FoswikiSkin
Branches: trunk
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
When viewing with the "cover=" parameter, the page is fully left justified, with no border box around the page. When viewed with the prepended print skin, on 1.1.9 the page has a border with shading. On trunk, the footer is shaded, and in both the text is offset from the left.

On 1.0.x, the results are identical.

The only difference in the generated HTML that I can find other than timestamps is the following:

Trunk:

cover=print
<link rel='stylesheet' href='/pub/System/PatternSkin/print.css' media='all' type='text/css' />

skin=print,pattern
<link rel='stylesheet' href='/pub/System/PatternSkin/print.css' media='print' type='text/css' />

Release 1.1.9:

cover=print
<style type="text/css" media="all">
   @import url("/pub/System/PatternSkin/print.css");

skin=print,pattern
<style type="text/css" media="print">
   @import url("/pub/System/PatternSkin/print.css");


The cause is due to templates setting the media type based upon the %URLPARAM{"cover"}% which is not set when using the skin prepend.

I don't believe that this is a bug. Resolved by a documentation update explaining the hard-coded media type settings.

-- GeorgeClark - 09 May 2014

ItemTemplate edit

Summary cover=print and skin=print,pattern should give identical results.
ReportedBy GeorgeClark
Codebase 1.1.9, trunk
SVN Range
AppliesTo Engine
Component FoswikiSkin
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:ecdd584f5be0
TargetRelease n/a
ReleasedIn 1.2.0
CheckinsOnBranches trunk
trunkCheckins distro:ecdd584f5be0
Release01x01Checkins
Topic revision: r3 - 29 May 2014, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy