Item12829: Revision info sometimes shows at the top and sometimes at the bottom

pencil
Priority: Normal
Current State: No Action Required
Released In: n/a
Target Release:
Applies To: Extension
Component: NatSkin
Branches:
Reported By: LeilaPearson
Waiting For:
Last Change By: MichaelDaum
Revision info is sometimes showing at the top of pages - underneath the level 1 heading - and other times it is showing at the bottom of pages (where I expect it to be).

For example:

Looking at body.nat.tmpl and view.nat.tmpl, I don't see anything obvious though I did find a couple of things that look like typos:
  • Missing TMPL:END in body.nat.tmpl line 9
8   %TMPL:DEF{"contentfooter_container"}%%CLEAR%<div class="natMainFooterContents">%TMPL:P{"contentfooter"}%</div>%TMPL:END%
9   %TMPL:DEF{"breadcrumbs_container"}%<div class='natBreadCrumbs'> %TMPL:P{"breadcrumbs::title"}% %TMPL:P{"breadcrumbs"}%</div>
10   %TMPL:DEF{"contentheader"}%%TMPL:P{"breadcrumbs_container"}%%CLEAR%%TMPL:END%
  • Reference to "aftercontents" instead of "afterbodycontents" in body.nat.tmpl line 68:
65   %TMPL:DEF{"afterbodycontents"}%%WEBCOMPONENT{"HtmlBottom"}%%TMPL:END%
66   
67   %{ assembly stage ---------------------------------------------------------- }%
68   %TMPL:DEF{"defaultbody"}%%TMPL:P{"beforebodycontents"}%%TMPL:P{"bodycontents"}%%TMPL:P{"aftercontents"}%%TMPL:END%
 

Fixing these had no effect on this behaviour though.

-- LeilaPearson - 29 Mar 2014

In NatSkin, rev info is supposed to be displayed following the first H1 element on the page. It will be shown at the bottom in case there is no H1 at.

Note best practice is to have one and only one H1 per page.

Technically speaking javascript has been used before to detect any H1 on a page and to move rev info into this position. This has been reworked to move any rev info on the server side as part of a completePageHandler for more robustness, less flickering and better compatibility to asyn page loads as used in AngularSkin / AngularPlugin.

-- MichaelDaum - 24 Dec 2014
 

ItemTemplate edit

Summary Revision info sometimes shows at the top and sometimes at the bottom
ReportedBy LeilaPearson
Codebase 1.1.9, trunk
SVN Range
AppliesTo Extension
Component NatSkin
Priority Normal
CurrentState No Action Required
WaitingFor
Checkins
ReleasedIn n/a
CheckinsOnBranches
trunkCheckins
masterCheckins
ItemBranchCheckins
Release01x01Checkins
Topic revision: r3 - 24 Dec 2014, MichaelDaum - This page was cached on 16 Jan 2020 - 04:33.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy