Item12819: Pass Interwiki links through expandCommonVariables

pencil
Priority: Enhancement
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Extension
Component: InterwikiPlugin
Branches: trunk
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
Macros are not expanded within a interwiki link definition.

The case here is specific to Foswiki.org. We need to map svn rev's to git hash references. A new macro plugin / macro is created that will map rev to ref.

distro:38a5a7f35c6c returns df46972 which could be used in a github url.

However the interwiki definition:

Foswikiref https://github.com/foswiki/foswiki/commit/Invalid svn rev revision $page of 'Foswiki'

fails to expand the macro in the rendered link.

Simple solution is to call expandCommonVariables on the link generated by InterwikiPlugin.

-- GeorgeClark - 23 Mar 2014

This fix is still needed, but unfortunately it's not enough to support the migration to Github. Since a single SVN rev can expand into multiple git commits, we need to override the returned url format.

 

ItemTemplate edit

Summary Pass Interwiki links through expandCommonVariables
ReportedBy GeorgeClark
Codebase 1.1.9, trunk
SVN Range
AppliesTo Extension
Component InterwikiPlugin
Priority Enhancement
CurrentState Closed
WaitingFor
Checkins distro:00c0288193a7
TargetRelease major
ReleasedIn 2.0.0
CheckinsOnBranches trunk
trunkCheckins distro:00c0288193a7
masterCheckins
ItemBranchCheckins
Release01x01Checkins
Topic revision: r4 - 05 Jul 2015, GeorgeClark - This page was cached on 27 Jun 2016 - 06:04.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License