You are here: Foswiki>Tasks Web>Item12656 (15 Dec 2015, GeorgeClark)Edit Attach

Item12656: Unit tests fail when run in a clean checkout

Priority: Urgent
Current State: Closed
Released In: n/a
Target Release: minor

Applies To: Extension
Component: UnitTestContrib
Branches: trunk

Reported By: CrawfordCurrie
Waiting For:
Last Change By: GeorgeClark

At long last I got around to examining the HTMLValidationTests failures. I thought it would be something simple, but it's a bit more complex than that.

Firstly, the error report arises because JQueryPlugin generates an error in a <div> inside the <head> block, which is illegal HTML. This needs to be fixed, and a <script> used instead.

Secondly, the error being reported arises because the TinyMCE JQuery plugin is not enabled. This isn't a problem per se, but it points to a deeper issue. When the tests run, the enabled plugins are stripped back and only the core subset of plugins is re-enabled. However in the course of this re-enablement, the Config.spec's of the installed plugins are not read, so a bunch of configuration gets missed.

The solution would seem to be for the test runner to load the Config.spec's. However there's a risk involved; it can't do this and then overwrite existing config that has been pulled in from LocalSite.cfg. So it either has to read the Config.spec's before it reads LocalSite.cfg, or it has to process the Config.spec inputs to ensure no overwrite happens.

-- CrawfordCurrie - 15 Nov 2013

Unit tests are running fine. Have been for a long time. Closing this task.

-- GeorgeClark - 15 Dec 2015

ItemTemplate edit

Summary	Unit tests fail when run in a clean checkout
ReportedBy	CrawfordCurrie
Codebase
SVN Range
AppliesTo	Extension
Component	UnitTestContrib
Priority	Urgent
CurrentState	Closed
WaitingFor
Checkins	distro:cf604305cbe3 distro:285de73a9929 distro:83794b9a86c8 distro:06135dd65b8a
TargetRelease	minor
ReleasedIn	n/a
CheckinsOnBranches	trunk
trunkCheckins	distro:cf604305cbe3 distro:285de73a9929 distro:83794b9a86c8 distro:06135dd65b8a
masterCheckins
ItemBranchCheckins
Release02x00Checkins
Release01x01Checkins