cross
Foswiki General Assembly will be held on 28th November 2019, 1200 UTC on Freenode IRC channel #foswiki-association. See AgendaTenthGeneralAssembly

Item12381: Configure UI and help text review

pencil
Priority: Normal
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Engine
Component: Configure
Branches: trunk master
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
General review and cleanup of the configure help text,

-- GeorgeClark - 03 Feb 2013

getRawValue() still expands contained references to $Foswiki::cfg

Example:

$Foswiki::cfg{ScriptUrlPath}/view$Foswiki::cfg{ScriptSuffix}

getRawValue() returns /bin/view

As a consequence the UI doesn't display any Expands to: ... See the defaulf for {ScriptUrlPaths}{view}.

-- MichaelDaum - 17 Jan 2015

The problem is deeper than getRawValue()

I've changed that code from an eval, do a recursive loop indexing through the keys, with no use of eval. There should be no way for that code to expand the embedded variables.

I think we need to find anyplace where configure uses eval (\$Foswiki::cfg$k) to dynamically access the hash and change it to a loop. Or find some other clever way to step into a hash without use of eval.

I've traced it specifically to the Configure::Query::_getSetParams(). When it does the eval to set the key, it expands it.

-- GeorgeClark - 17 Jan 2015

Yea that seems to be a good idea. For now I get lots of errors of the form

Use of uninitialized value in string at (eval 20898) line 1.

presumably as a consequence of $k not being defined sometimes.

-- MichaelDaum - 17 Jan 2015

No, getRaw was failing for undefined keys that have spec. No need to do an assignment, just return the undef. fixed.

-- GeorgeClark - 18 Jan 2015
 

ItemTemplate edit

Summary Configure UI and help text review
ReportedBy GeorgeClark
Codebase trunk
SVN Range
AppliesTo Engine
Component Configure
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:b4aef1844cef distro:7da8957dbce4 distro:9707e91e2c7e distro:016e0d369778 distro:54c12516fa8a distro:cf11b887c2fb distro:7bc0ebf73815 FoswikiOrgPlugin:3483cb29c539 distro:831bb1ac617c CharsetConverterContrib:7c3a78dc46d5 DBIStoreContrib:04e11b01a2ff DirectedGraphPlugin:fe825ee4892e EmptyContrib:0e1fe914efa3 FortunePlugin:55eb26bbbc0f LogDispatchContrib:f91337b82963 NewUserPlugin:b05a0b7bcfb7 PerlPlugin:b18019797e4b TablesContrib:fe805cc8f1c6 distro:2e1c8bda5e64 distro:ead79ae8ed59 distro:a1f331b5c5f6 distro:74afa4f1d4b9 distro:2aa636942c1e distro:53647781243b distro:787053b725e5 distro:00ce714c73e6 distro:5eb153f2ee8f distro:e7a734af4fc0 distro:360d27e88d3b distro:7175c9b5877f distro:cfc00b801fb2 distro:bd7a48212100 distro:2d707ddacca0 distro:787fcbec35d4 distro:fcfa898fee6d distro:ce1cc17a99b3 distro:81ec50b92d49 FortunePlugin:89e3cd10fb6c distro:282f1cc80111
TargetRelease major
ReleasedIn 2.0.0
CheckinsOnBranches trunk master
trunkCheckins distro:b4aef1844cef distro:7da8957dbce4 distro:9707e91e2c7e distro:016e0d369778
masterCheckins distro:54c12516fa8a distro:cf11b887c2fb distro:7bc0ebf73815 FoswikiOrgPlugin:3483cb29c539 distro:831bb1ac617c CharsetConverterContrib:7c3a78dc46d5 DBIStoreContrib:04e11b01a2ff DirectedGraphPlugin:fe825ee4892e EmptyContrib:0e1fe914efa3 FortunePlugin:55eb26bbbc0f LogDispatchContrib:f91337b82963 NewUserPlugin:b05a0b7bcfb7 PerlPlugin:b18019797e4b TablesContrib:fe805cc8f1c6 distro:2e1c8bda5e64 distro:ead79ae8ed59 distro:a1f331b5c5f6 distro:74afa4f1d4b9 distro:2aa636942c1e distro:53647781243b distro:787053b725e5 distro:00ce714c73e6 distro:5eb153f2ee8f distro:e7a734af4fc0 distro:360d27e88d3b distro:7175c9b5877f distro:cfc00b801fb2 distro:bd7a48212100 distro:2d707ddacca0 distro:787fcbec35d4 distro:fcfa898fee6d distro:ce1cc17a99b3 distro:81ec50b92d49 FortunePlugin:89e3cd10fb6c distro:282f1cc80111
ItemBranchCheckins
Release01x01Checkins
Topic revision: r31 - 05 Jul 2015, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy