cross
New Foswiki release 2.1.6 is available with important security fixes.
Sourceforge foswiki email lists being discontinued. Subscribe to the new Foswiki announce and discuss lists at MailingLists
You are here: Foswiki>Tasks Web>Item12202 (05 Jul 2015, GeorgeClark)Edit Attach

Item12202: DST shift marks old RSS feed items as new / value of isotz must be date dependant

pencil
Priority: Normal
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Engine
Component: FoswikiTime
Branches: trunk
Reported By: FlorianSchlichting
Waiting For:
Last Change By: GeorgeClark
Yesterday, Europe switched from summer time to winter time, and all the old RSS feed items were marked as new / changed. This turned out to be due to a change in the dc:date field, which was changed from +02:00 to +01:00 for all items, those changed today as well as those changed last week.

That is to say, the iso timezone offset is date dependant, so when $Foswiki::cfg{DisplayTimeValues} is set to 'servertime', we need to look at the date in question when determining the $isotz offset value.

The current handling of this was introduced by CrawfordCurrie in distro:c2fcd6e926db, which does much more than just fixing Item1016, but in an unnecessarily complicated fashion. Most of this can just be replaced by POSIX::strftime's %z format specifier.

-- FlorianSchlichting - 29 Oct 2012

I had to revert this. Looks like trunk.foswiki.org doesn't have POSIX::strftime available.

-- GeorgeClark - 29 Oct 2012

fixed, and added two unit tests as well.

Is this fit for 1.1.6?

-- FlorianSchlichting - 31 Oct 2012

Time.pm fixes scare me a bit. Our time code is somewhat fragile. I ran the unit tests and they seem fine, but often problems only show up in specific time zones and server configurations. For that reason I think that this one is best for 1.2.

-- GeorgeClark - 31 Oct 2012
 
Topic revision: r10 - 05 Jul 2015, GeorgeClark - This page was cached on 21 Mar 2018 - 20:09.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License