You are here: Foswiki>Tasks Web>Item12148 (05 Jul 2015, GeorgeClark)Edit Attach

Item12148: EditRowPlugin improvements

pencil
Priority: Urgent
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Engine
Component: EditRowPlugin
Branches: trunk
Reported By: SvenDowideit
Waiting For:
Last Change By: GeorgeClark
  1. when the yellow stain is added, is causes the table to jump around, as its resizing. can the stain be done as a css background and then the click even be from a fallthrough event
  2. some tooltips are missing (pencil)
  3. more row makes no sense if there is only one row
  4. the large crosshair cursor is a strange choice for clicking on the stain
  5. in the plugin topic uploaded to f.o, there is a missing image when showing stain in the prose
  6. can there be an 'add row' button without hitting full edit? (oh, maybe changerow=on is broken? (see WikiApp3 ))

-- SvenDowideit - 13 Oct 2012

yep, its still broken.

I still can't add a row (clicking the edit button, then clicking the plus sign takes me back to view)

and the UI still jumps around like a maniac when you move your mouse.

in edit mode, the header= attribute isn't rendered

Major Urgent

Further investigation suggests to me that there is nothing coded to ERP and ETP that prevent them from both being enabled. which is bad when users upgrade. (and yes, they do this inplace irrespective of our hopes and desires)

so i'd like to see
  1. something at run time that will disable one or the other
  2. a checker in configure that errors out if both are selected, suggesting the user use ERP unless they know what they are doing
  3. a checker that tells the user to prefer ERP if only ETP is on

plus - EDITTABLE is used without an existing table to create a new one.

ala

Model
Description

(broken on t.f.o)

-- SvenDowideit - 16 Nov 2012

Does anybody else get a crash like this, viewing this topic with http://trunk.foswiki.org/Tasks/Item12148:
Can't locate object method "end_of_input" via package "Foswiki::Plugins::EditRowPlugin::TableParser" at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Tables/Reader.pm line 99.
 at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Tables/Reader.pm line 99.
   Foswiki::Tables::Reader::__ANON__('end_of_input') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Tables/Parser.pm line 226
   Foswiki::Tables::Parser::parse('   1 when the yellow stain is added, is causes the table to j...', 'CODE(0x227c0c8)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Tables/Reader.pm line 102
   Foswiki::Tables::Reader::parse('Foswiki::Plugins::EditRowPlugin::TableParser=HASH(0x2278f80)', '   1 when the yellow stain is added, is causes the table to j...', 'Foswiki::Meta=HASH(0xafdaa0)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Plugins/EditRowPlugin/TableParser.pm line 40
   Foswiki::Plugins::EditRowPlugin::TableParser::parse('Foswiki::Plugins::EditRowPlugin::TableParser=HASH(0x2278f80)', '   1 when the yellow stain is added, is causes the table to j...', 'Foswiki::Meta=HASH(0xafdaa0)', 'HASH(0x21d6168)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Plugins/EditRowPlugin/View.pm line 61
   Foswiki::Plugins::EditRowPlugin::View::process('   1 when the yellow stain is added, is causes the table to j...', 'Tasks', 'Item12148', 'Foswiki::Meta=HASH(0xafdaa0)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Plugins/EditRowPlugin.pm line 45
   Foswiki::Plugins::EditRowPlugin::commonTagsHandler('   1 when the yellow stain is added, is causes the table to j...', 'Item12148', 'Tasks', 0, 'Foswiki::Meta=HASH(0xafdaa0)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Plugin.pm line 306
   Foswiki::Plugin::invoke('Foswiki::Plugin=HASH(0xfed300)', 'commonTagsHandler', '   1 when the yellow stain is added, is causes the table to j...', 'Item12148', 'Tasks', 0, 'Foswiki::Meta=HASH(0xafdaa0)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Plugins.pm line 341
   Foswiki::Plugins::dispatch('Foswiki::Plugins=HASH(0xb3e210)', 'commonTagsHandler', '   1 when the yellow stain is added, is causes the table to j...', 'Item12148', 'Tasks', 0, 'Foswiki::Meta=HASH(0xafdaa0)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki.pm line 3382
   Foswiki::expandMacros('Foswiki=HASH(0x673958)', '   1 when the yellow stain is added, is causes the table to j...', 'Foswiki::Meta=HASH(0xafdaa0)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Meta.pm line 3171
   Foswiki::Meta::expandMacros('Foswiki::Meta=HASH(0xafdaa0)', '   1 when the yellow stain is added, is causes the table to j...') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI/View.pm line 451
   Foswiki::UI::View::_prepare('   1 when the yellow stain is added, is causes the table to j...', 'Foswiki::Meta=HASH(0xafdaa0)', 0) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI/View.pm line 431
   Foswiki::UI::View::view('Foswiki=HASH(0x673958)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI.pm line 316
   Foswiki::UI::__ANON__() called at /usr/local/lib/perl5/site_perl/5.10.1/Error.pm line 419
   eval {...} called at /usr/local/lib/perl5/site_perl/5.10.1/Error.pm line 411
   Error::subs::try('CODE(0x603c88)', 'HASH(0xa92bc0)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI.pm line 435
   Foswiki::UI::_execute('Foswiki::Request=HASH(0xa705a0)', 'CODE(0x9fd480)', 'view', 1) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI.pm line 274
   Foswiki::UI::handleRequest('Foswiki::Request=HASH(0xa705a0)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Engine/CGI.pm line 41
   Foswiki::Engine::CGI::run('Foswiki::Engine::CGI=HASH(0x7833c8)') called at /home/trunk.foswiki.org/core/bin/view line 29.

Sorry, forgot to check a bit in

-- CrawfordCurrie - 27 Nov 2012

Taken Sven's points:
  1. when the yellow stain is added, is causes the table to jump around, as its resizing. can the stain be done as a css background and then the click even be from a fallthrough event - SvenDowideit I don't see this - do you have an example?
  2. some tooltips are missing (pencil) fixed
  3. more row makes no sense if there is only one row SvenDowideit I beg your pardon?
  4. the large crosshair cursor is a strange choice for clicking on the stain changed to pointer to match button behaviour
  5. in the plugin topic uploaded to f.o, there is a missing image when showing stain in the prose fixed
  6. can there be an 'add row' button without hitting full edit? (oh, maybe changerow=on is broken? (see WikiApp3 )) not as the plugin is currently coded, but this could be added as a feature

-- CrawfordCurrie - 05 Dec 2012

No feedback from Sven, so assuming this is OK now and closing.

-- CrawfordCurrie - 23 Mar 2013
Topic revision: r22 - 05 Jul 2015, GeorgeClark - This page was cached on 29 Jun 2016 - 21:56.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License