cross
New Foswiki release 2.1.6 is available with important security fixes.
Sourceforge foswiki email lists being discontinued. Subscribe to the new Foswiki announce and discuss lists at MailingLists
You are here: Foswiki>Tasks Web>Item12060 (05 Jul 2015, GeorgeClark)Edit Attach

Item12060: INCLUDE macros "warn" attribute does not accept dollar-escapes

pencil
Priority: Enhancement
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Engine
Component: INCLUDE
Branches: trunk
Reported By: BjoernKautler
Waiting For:
Last Change By: GeorgeClark
When using the INCLUDE macro it is impossible to use any ICON macro like %X% in the warn attribute.
The expanded Macro contains double quotes that immediately end the warn attribute value and thus you only get: <img src=
Escaping it with $percntX$percnt does not work and will produce: $percntX$percnt
The only way around currently is to manually stuff the IMG tag into the "warn" attribute.
If it would understand $percntX$percnt, I guess it would work.

-- BjoernKautler - 29 Aug 2012

<img src=

Foswiki 1.2 is changing to generate single quotes in all html. (where practical).

Tested here on http://trunk.foswiki.org/Tasks/Item12060 by changing the =%X% and other macros to single quotes.

-- AdminUser - 02 Jun 2014

Your suggested solution is the way to go. INCLUDE will be changed to call Foswiki::expandStandardEscapes() on the warn= string.

-- GeorgeClark - 03 Jun 2014

I have reviewed the code changes and deem this ready for release, as discussed at ReleaseMeeting01x02_20140616

-- CrawfordCurrie - 17 Jun 2014

 

ItemTemplate edit

Summary INCLUDE macros "warn" attribute does not accept dollar-escapes
ReportedBy BjoernKautler
Codebase 1.1.9, 1.1.8, 1.1.7, 1.1.6, 1.1.5, trunk
SVN Range
AppliesTo Engine
Component INCLUDE
Priority Enhancement
CurrentState Closed
WaitingFor
Checkins distro:974ee2abadfe distro:4ab29eb3590f
TargetRelease major
ReleasedIn 2.0.0
CheckinsOnBranches trunk
trunkCheckins distro:974ee2abadfe distro:4ab29eb3590f
Release01x01Checkins
Topic revision: r11 - 05 Jul 2015, GeorgeClark - This page was cached on 21 Mar 2018 - 20:29.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License