You are here: Foswiki>Tasks Web>Item11590 (30 Dec 2014, GeorgeClark)Edit Attach

Item11590: Why are the pattern skin fonts set in #patternPage a div id half way into the page?

pencil
Priority: Normal
Current State: No Action Required
Released In: n/a
Target Release: n/a
Applies To: Extension
Component: PatternSkin
Branches:
Reported By: SvenDowideit
Waiting For:
Last Change By: GeorgeClark
surely this kind of css could use the html body selection and thus apply to any skin, and all rendered html?

I presume that is why the styling of the 'Create Task' jq popup I just added is naf - the dialog html gets added to the end of the body.

There are a number of pains here
  1. the font is set on an id
  2. the id is nested quite a way down
  3. why put general styling on a skin and application specific css class or element? Would it not be better to style the body with generally good defaults, and then use classes and id's to tweak them?

(I ask because I don't know, but as a programmer, is feels strange.)

-- SvenDowideit - 01 Mar 2012

Strange, there has been no #patternPage since that changed to .foswikiPage on 16 Jun 2009, see http://trac.foswiki.org/changeset/4168.

When I wrote that I had a kind of font size default in mind, a reset on the body tag and an override (the actual size) on the nearest div (not half a page away).

Today I wouldn't write it that way.

-- ArthurClemens - 06 Mar 2012

Setting to no action.

-- GeorgeClark - 30 Dec 2014
 

ItemTemplate edit

Summary Why are the pattern skin fonts set in #patternPage a div id half way into the page?
ReportedBy SvenDowideit
Codebase 1.1.4, trunk
SVN Range
AppliesTo Extension
Component PatternSkin
Priority Normal
CurrentState No Action Required
WaitingFor
Checkins
TargetRelease n/a
ReleasedIn n/a
CheckinsOnBranches
trunkCheckins
masterCheckins
ItemBranchCheckins
Release01x01Checkins
Topic revision: r3 - 30 Dec 2014, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy