cross
New Foswiki release 2.1.6 is available with important security fixes.
Sourceforge foswiki email lists being discontinued. Subscribe to the new Foswiki announce and discuss lists at MailingLists
You are here: Foswiki>Tasks Web>Item11389 (05 Jul 2015, GeorgeClark)Edit Attach

Item11389: Change named anchor links to target IDs.

pencil
Priority: Enhancement
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Engine
Component:
Branches: trunk
Reported By: ArthurClemens
Waiting For:
Last Change By: GeorgeClark
Names anchors have been deprecated.
<div id="some_anchor_name"></div>
should work with all browsers.

-- ArthurClemens - 25 Dec 2011

The a-name element should be replaced with an inline span-id ... not a block element. For tml headings, the h-element can take the id itself, i.e. no separate element is needed anymore.

-- MichaelDaum - 25 Dec 2011

Correct.

-- ArthurClemens - 25 Dec 2011

Right. And it would have killed you to fix the unit tests alongside your code?

-- OlivierRaginel - 26 Feb 2012

So it seems your fix fixed also the "weird double-anchor TOC issue that was exposed in SemiAutomaticTestCaseTests::test_TestCaseAutoTOCManual

I've fixed all the unit tests for you, at least all the ones I saw failing. Would be great if people would start considering changing unit tests when they change the rendering...

-- OlivierRaginel - 26 Feb 2012

I did a search in the test folders and found:
  • trunk/UnitTestContrib/test/unit/FormattingTests.pm
  • trunk/UnitTestContrib/test/unit/TOCTests.pm
  • trunk/core/data/TestCases/TestCaseAutoTOC.txt
  • trunk/core/data/TestCases/TestCaseAutoTOCManual.txt
and fixed those (r. 14098, 14099).

I suspected there could be more. So thanks for the fixing.

-- ArthurClemens - 26 Feb 2012
 
Topic revision: r11 - 05 Jul 2015, GeorgeClark - This page was cached on 23 Jul 2018 - 15:04.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy