Item11256: typo in path: JavaScriptFiles -> JavascriptFiles

There is a typo in the path to foswikiDate.js, the directory is named JavascriptFiles, not JavaScriptFiles.

--- a/data/System/JSCalendarContribInline.txt
+++ b/data/System/JSCalendarContribInline.txt
@@ -49,7 +49,7 @@ Inline include of [[JSCalendarContrib]] HTML for use in forms.
   requires="JSCalendarContrib/calendar-setup,JSCalendarContrib/date"
 }%%TMPL:P{
   "LIBJS"
-  id="JavaScriptFiles/foswikiDate"
+  id="JavascriptFiles/foswikiDate"
   requires=""
 }%%STOPINCLUDE%
 

-- FlorianSchlichting - 16 Nov 2011

hang on, there is no foswikiDate.js anyway??

-- FlorianSchlichting - 16 Nov 2011

BuildContrib builds the missing (compressed) .js files from a _src.js or .uncompressed.js if it exists.

pseudo-install.pl will also try to produce a link & gzip'd version.

-- PaulHarvey - 16 Nov 2011

thanks for your comment, but there's no file named foswikiDate* anywhere in the tree, neither in the Foswiki-1.1.3 tar.gz, nor in JSCalendarContrib. I don't see any malfunction, either. Perhaps this line is bogus?

-- FlorianSchlichting - 16 Nov 2011

It's been added for Foswiki 1.1.4. Does this mean the current JSCalendarContrib depends on Foswiki 1.1.4? See Item11020. Waiting for feedback from george/arthur.

I committed your change to svn. I would be especially delighted if you were to RequestAccessToSubversion, if you are so inclined

-- PaulHarvey - 16 Nov 2011

There is a fallback in case foswikiDate is not available: if (foswiki && foswiki.Date) (foswiki_src.js).

But still foswikiDate is tried to load because of

%TMPL:P{
  "LIBJS"
  id="JavaScriptFiles/foswikiDate"
  requires=""
}%

That should be conditional. Or we make it conditional on version 1.2 (a later Plugins version).

-- ArthurClemens - 16 Nov 2011

Please don't close tasks that are associated with core plugins. They need to stay in waiting for release until the new release it built.

-- GeorgeClark - 20 Nov 2011

Commenting is disabled while not logged in