You are here: Foswiki>Tasks Web>Item10933 (05 Jul 2015, GeorgeClark)Edit Attach

Item10933: MAKETEXT silently returns incorrect strings when running from the cmdline.

pencil
Priority: Normal
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Engine
Component: I18N
Branches:
Reported By: SvenDowideit
Waiting For:
Last Change By: GeorgeClark
if you set the ChrSet to '' as configure tells you is the default

then I18N::fromSiteCharSet _silently _returns an undef in the 'good perl' error condition

imo it should die - as the output is totally wrong, or figure out how to fix itself..

it seems there are a number of places in the code where it assumes that $Foswiki::cfg{Site}{CharSet} is actually set to a reasonable value.

so I'm going to set it to

    $Foswiki::cfg{Site}{CharSet} = CGI::charset() || 'iso-8859-1' unless (defined($Foswiki::cfg{Site}{CharSet}) and $Foswiki::cfg{Site}{CharSet} ne '');

and then we should be able to make the error condition die - as it should be quite uncommon. (unless someone is using maketext without first initialising the Foswiki object - which is a bad idea all round.

If it was fixed in trunk can we actually put this in waiting for release? Or did Sven want the fix in 1.1.4. If so fix and put Waiting for release

-- SvenDowideit - 30 Jun 2011

I do not see a command line feature as a release blocker and the fact it was raised a month ago and not fixed right away sort of confirms that this is not so urgent.

Downgrading

-- KennethLavrsen - 30 Jul 2011

This is patched in trunk. ... is it actually a fix? Crawford, any idea?

-- GeorgeClark - 23 Dec 2014

No, sorry, not a clue. Not something I have ever looked at.

-- CrawfordCurrie - 08 Feb 2015

As patch is applied, marking waiting for release.

-- GeorgeClark - 11 Feb 2015
 

ItemTemplate edit

Summary MAKETEXT silently returns incorrect strings when running from the cmdline.
ReportedBy SvenDowideit
Codebase 1.1.3, trunk
SVN Range
AppliesTo Engine
Component I18N
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:33e06fa2dced
TargetRelease major
ReleasedIn 2.0.0
CheckinsOnBranches
trunkCheckins
masterCheckins
ItemBranchCheckins
Release01x01Checkins
Topic revision: r8 - 05 Jul 2015, GeorgeClark - This page was cached on 23 Jul 2016 - 13:12.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License