Item10872: Viewing old rev of topic re-renders all images to previous size

Priority: Urgent
Current State: Waiting for Feedback
Released In: n/a
Target Release: n/a
Applies To: Extension
Component: ImageGalleryPlugin
Reported By: GeorgeClark
Waiting For: MichaelDaum
Last Change By: MichaelDaum
Topic with 20 very large images. Rev 1 of the topic used %IMAGEGALLERY{}% with the default medium thumbnail size. Rev 2 used %IMAGEGALLERY{size="huge"}%

Viewing an older revision of the topic regenerates all of the thumbnails with the smaller size - which causes the worker on apache to run around 5 minutes of 100% cpu. Then viewing the current rev regenerates all of the thumbnails again. I'm not sure what happens if two requests simultaneously ask fro rev 1 and rev 2 of the topic - will we have dueling images in the pub/images directory?

Viewing old revisions of the topic should not be rebuilding images. Either the macro needs to be not rendered, or the images need to be rev'd as well to avoid re-rendering.

See SupportDynamicGeneratedAttachments

-- GeorgeClark - 14 Jun 2011

Note for DirectedGraphPlugin - which had the same issue, I changed the plugin so it does not render the macros for the diff context, or if rev not= current rev. This avoids regenerating all of the attachments on old versions.

-- GeorgeClark - 14 Jun 2011

Sounds good suppressing rendering new thumbnails in a diff context.

-- MichaelDaum - 14 Jun 2011
 

ItemTemplate edit

Summary Viewing old rev of topic re-renders all images to previous size
ReportedBy GeorgeClark
Codebase trunk
SVN Range
AppliesTo Extension
Component ImageGalleryPlugin
Priority Urgent
CurrentState Waiting for Feedback
WaitingFor MichaelDaum
Checkins
TargetRelease n/a
ReleasedIn n/a
Topic revision: r3 - 14 Jun 2011, MichaelDaum
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License