Item10531: NativeSearchContrib duplicates results on 1.1.3

Word and Keyword type searches using NativeSearchContrib on 1.1.3 release branch returns duplicated results.

Unit tests fail, and also observed issue on live system.

2 failures:
Fn_SEARCH::verify_scope_all_type_word_NativeSearch

Expected:'RealBeer
VirtualBeer
VirtualLife
'
 But got:'RealBeer
RealBeer
VirtualBeer
VirtualLife
'
 at /var/www/foswiki/trunk/core/lib/Unit/TestCase.pm line 271
        Unit::TestCase::assert_str_equals('Fn_SEARCH=HASH(0x883b508)', 'RealBeer\x{a}VirtualBeer\x{a}VirtualLife\x{a}', 'RealBeer\x{a}RealBeer\x{a}VirtualBeer\x{a}VirtualLife\x{a}') called at /var/www/foswiki/trunk/core/test/unit/Fn_SEARCH.pm line 254
        Fn_SEARCH::verify_scope_all_type_word('Fn_SEARCH=HASH(0x883b508)') called at (eval 303) line 4
        Unit::TestCase::__ANON__('Fn_SEARCH=HASH(0x883b508)') called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 383
        Unit::TestRunner::__ANON__() called at /var/www/foswiki/trunk/core/lib/CPAN/lib/Error.pm line 379
        eval {...} called at /var/www/foswiki/trunk/core/lib/CPAN/lib/Error.pm line 371
        Error::subs::try('CODE(0x12085600)', 'HASH(0x10244630)') called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 402
        Unit::TestRunner::runOne('Fn_SEARCH=HASH(0x883b508)', 'Fn_SEARCH', undef) called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 306
        Unit::TestRunner::worker('Unit::TestRunner=HASH(0x84f63b8)', 'Fn_SEARCH', 'undef', 'worker_output.7822.Fn_SEARCH') called at /var/www/foswiki/trunk/core/test/unit/../bin/TestRunner.pl line 123
 at /var/www/foswiki/trunk/core/test/unit/FoswikiTestCase.pm line 38
        FoswikiTestCase::__ANON__('\x{a}Expected:\'RealBeer\x{a}VirtualBeer\x{a}VirtualLife\x{a}\'\x{a} But got:\'Re...') called at /var/www/foswiki/trunk/core/lib/Unit/TestCase.pm line 206
        Unit::TestCase::assert('Fn_SEARCH=HASH(0x883b508)', '', 'Expected:\'RealBeer\x{a}VirtualBeer\x{a}VirtualLife\x{a}\'\x{a} But got:\'Rea...') called at /var/www/foswiki/trunk/core/lib/Unit/TestCase.pm line 271
        Unit::TestCase::assert_str_equals('Fn_SEARCH=HASH(0x883b508)', 'RealBeer\x{a}VirtualBeer\x{a}VirtualLife\x{a}', 'RealBeer\x{a}RealBeer\x{a}VirtualBeer\x{a}VirtualLife\x{a}') called at /var/www/foswiki/trunk/core/test/unit/Fn_SEARCH.pm line 254
        Fn_SEARCH::verify_scope_all_type_word('Fn_SEARCH=HASH(0x883b508)') called at (eval 303) line 4
        Unit::TestCase::__ANON__('Fn_SEARCH=HASH(0x883b508)') called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 383
        Unit::TestRunner::__ANON__() called at /var/www/foswiki/trunk/core/lib/CPAN/lib/Error.pm line 379
        eval {...} called at /var/www/foswiki/trunk/core/lib/CPAN/lib/Error.pm line 371
        Error::subs::try('CODE(0x12085600)', 'HASH(0x10244630)') called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 402
        Unit::TestRunner::runOne('Fn_SEARCH=HASH(0x883b508)', 'Fn_SEARCH', undef) called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 306
        Unit::TestRunner::worker('Unit::TestRunner=HASH(0x84f63b8)', 'Fn_SEARCH', 'undef', 'worker_output.7822.Fn_SEARCH') called

---------------------------
Fn_SEARCH::verify_scope_all_type_keyword_NativeSearch

Expected:'FamouslyBeered
RealBeer
VirtualBeer
VirtualLife
'
 But got:'FamouslyBeered
FamouslyBeered
RealBeer
RealBeer
VirtualBeer
VirtualBeer
VirtualLife
'
 at /var/www/foswiki/trunk/core/lib/Unit/TestCase.pm line 271
        Unit::TestCase::assert_str_equals('Fn_SEARCH=HASH(0x883b508)', 'FamouslyBeered\x{a}RealBeer\x{a}VirtualBeer\x{a}VirtualLife\x{a}', 'FamouslyBeered\x{a}FamouslyBeered\x{a}RealBeer\x{a}RealBeer\x{a}VirtualBeer\x{a}V...') called at /var/www/foswiki/trunk/core/test/unit/Fn_SEARCH.pm line 288
        Fn_SEARCH::verify_scope_all_type_keyword('Fn_SEARCH=HASH(0x883b508)') called at (eval 321) line 4
        Unit::TestCase::__ANON__('Fn_SEARCH=HASH(0x883b508)') called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 383
        Unit::TestRunner::__ANON__() called at /var/www/foswiki/trunk/core/lib/CPAN/lib/Error.pm line 379
        eval {...} called at /var/www/foswiki/trunk/core/lib/CPAN/lib/Error.pm line 371
        Error::subs::try('CODE(0x12ee3e60)', 'HASH(0x134e9220)') called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 402
        Unit::TestRunner::runOne('Fn_SEARCH=HASH(0x883b508)', 'Fn_SEARCH', undef) called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 306
        Unit::TestRunner::worker('Unit::TestRunner=HASH(0x84f63b8)', 'Fn_SEARCH', 'undef', 'worker_output.7822.Fn_SEARCH') called at /var/www/foswiki/trunk/core/test/unit/../bin/TestRunner.pl line 123
 at /var/www/foswiki/trunk/core/test/unit/FoswikiTestCase.pm line 38
        FoswikiTestCase::__ANON__('\x{a}Expected:\'FamouslyBeered\x{a}RealBeer\x{a}VirtualBeer\x{a}VirtualLife\x{a}\...') called at /var/www/foswiki/trunk/core/lib/Unit/TestCase.pm line 206
        Unit::TestCase::assert('Fn_SEARCH=HASH(0x883b508)', '', 'Expected:\'FamouslyBeered\x{a}RealBeer\x{a}VirtualBeer\x{a}VirtualLife\x{a}\'...') called at /var/www/foswiki/trunk/core/lib/Unit/TestCase.pm line 271
        Unit::TestCase::assert_str_equals('Fn_SEARCH=HASH(0x883b508)', 'FamouslyBeered\x{a}RealBeer\x{a}VirtualBeer\x{a}VirtualLife\x{a}', 'FamouslyBeered\x{a}FamouslyBeered\x{a}RealBeer\x{a}RealBeer\x{a}VirtualBeer\x{a}V...') called at /var/www/foswiki/trunk/core/test/unit/Fn_SEARCH.pm line 288
        Fn_SEARCH::verify_scope_all_type_keyword('Fn_SEARCH=HASH(0x883b508)') called at (eval 321) line 4
        Unit::TestCase::__ANON__('Fn_SEARCH=HASH(0x883b508)') called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 383
        Unit::TestRunner::__ANON__() called at /var/www/foswiki/trunk/core/lib/CPAN/lib/Error.pm line 379
        eval {...} called at /var/www/foswiki/trunk/core/lib/CPAN/lib/Error.pm line 371
        Error::subs::try('CODE(0x12ee3e60)', 'HASH(0x134e9220)') called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 402
        Unit::TestRunner::runOne('Fn_SEARCH=HASH(0x883b508)', 'Fn_SEARCH', undef) called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 306
        Unit::TestRunner::worker('Unit::TestRunner=HASH(0x84f63b8)', 'Fn_SEARCH', 'undef', 'worker_output.7822.Fn_SEARCH') called

-- GeorgeClark - 24 Mar 2011

A code change in the forking search (which was the template for native) didn't bubble through. Fixed.

-- CrawfordCurrie - 26 Mar 2011

Did you want to include a print to STDERR in the code?

        print STDERR "NATIVE ".Data::Dumper->Dump([$textMatches])."\n"; 

-- GeorgeClark - 26 Mar 2011

Bah.

-- CrawfordCurrie - 28 Mar 2011

Commenting is disabled while not logged in