Item10275: The 'More actions' button of FamFamFamContrib toolbar doesn't work

Priority: Normal
Current State: Closed
Released In: 1.1.3
Target Release: patch
Applies To: Extension
Component: FamFamFamContrib
Branches:
Reported By: IngoKappler
Waiting For: Main.IngoKappler
Last Change By: KennethLavrsen
Using in %USERSWB%.SitePreferences Set SKIN = famfamfam, pattern replaces the standard toolbar buttons with a more comprehensive toolbar. The last button for "More actions" doesn't work because it points to:
http://name/fw/bin/oops/Main/SitePreferences?template=oopsmore
instead of
http://name/fw/bin/view/Main/SitePreferences?template=more&maxrev=11&currrev=11

It starts working by just using:
http://name/fw/bin/oops/Main/SitePreferences?template=more
but then still misses the revisions.

Related code is in view.famfamfam.tmpl where it could be changed from:
a href="http://foswiki.org/bin/oops/Tasks/Item10275?template=oopsmore" title="More actions"
to
a href="%SCRIPTURL{"oops"}%/%WEB%/%TOPIC%?template=more&maxrev=%REVINFO{"$rev"}%&currrev=%REVINFO{"$rev"}%" title="More actions"

However, there are reasons to not just fix it but to probably also keep backward compatibility. On a 1.0.10 installation the default parameters of a "More topic actions" link are similar to:
https://x.x.x.x/foswiki/bin/oops/Sandbox/VotePluginTests?template=oopsmore&param1=1&param2=1

-- IngoKappler - 20 Jan 2011

I'll probably fix it myself, once I find the time using IF{"condition" ...} together with WIKIVERSION

-- IngoKappler - 22 Jan 2011

Well, in the meantime I thought using IF introduces some overhead and e.g. %WIKIVERSION% doesn't give just the version number, so some more code is required to just get the number to compare against. Therefore I decided at least for now to just fix it for >=1.1 ignoring backward compatibility. This was also supported by the fact that even the EditTablePlugin 4.39 isn't backward compatible with 1.0 anymore. So why making it difficult just for a small button many users may not even use.

-- IngoKappler - 25 Jan 2011

harumpf - actually, i have er.... mmmm, plonk - yes, i need to upgrade a few more foswikis smile

good job, and its the right decision - if i need it on 1.0, i'll figure out a fix (likely by adding a famfamfam10 skin tmpl.

cheers Sven

-- SvenDowideit - 25 Jan 2011

Hi Sven, I played with the following code but wasn't sure how to extract the pure number from %WIKIVERSION% in a template file when assuming that pure perl isn't possible, isn't it? Also this decision whould have to be made on each page reload, so that's a potential speed thing maybe neglectable.

Here the code which worked on 1.1.x but not tested on 1.0.x. Issue is "1.1 >= 1.1" which obviously should be something like "%WIKIVERSION% >= 1.1".

%IF{ "1.1 >= 1.1"
  then="%TMPL:DEF{"top:toolbarbutton_more"}%<span>
        <a href="%SCRIPTURL{"oops"}%/%WEB%/%TOPIC%?template=more&maxrev=%REVINFO{"$rev"}%&currrev=%REVINFO{"$rev"}%" title=
"More actions">
                <img alt="more" src="%PUBURL%/%SYSTEMWEB%/FamFamFamSilkIcons/wrench.png" width="16" height="16" />
        </a></span>%TMPL:END%
  else="%TMPL:DEF{"top:toolbarbutton_more_1.0.x"}%<span>
        <a href="%SCRIPTURL{"oops"}%/%WEB%/%TOPIC%?template=oopsmore" title="More actions">
                <img alt="more" src="%PUBURL%/%SYSTEMWEB%/FamFamFamSilkIcons/wrench.png" width="16" height="16" />
        </a></span>%TMPL:END%
}%

-- IngoKappler - 25 Jan 2011

BTW, I like this way to quickly get a nice toolbar up and running. smile

-- IngoKappler - 25 Jan 2011

Hi Ingo, please don't forget to apply to Release01x01 branch too smile

In case you forget, also add this task item to the release notes of the extension, and use WaitingForRelease

-- PaulHarvey - 26 Jan 2011

Committed it to branch now. I still didn't set Waiting for release because I also plan to release the extension in the common way. So actually I am not yet finished (version changes still missing) and I have 3 tasks related to FamFamFamContrib right now. I'd prefer finishing them all.

Once there I will set CurrentState to Waiting for Release and ReleasedIn to 1.1.3.

-- IngoKappler - 26 Jan 2011

Cool, that's perfectly fine.

-- PaulHarvey - 26 Jan 2011

Extension has been released. Still Waiting for Release as this is a default extension.

-- IngoKappler - 26 Jan 2011
 

ItemTemplate edit

Summary The 'More actions' button of FamFamFamContrib toolbar doesn't work
ReportedBy IngoKappler
Codebase 1.1.2
SVN Range
AppliesTo Extension
Component FamFamFamContrib
Priority Normal
CurrentState Closed
WaitingFor IngoKappler
Checkins distro:40490c0a861b distro:1b2c6cd7b00c
TargetRelease patch
ReleasedIn 1.1.3
Topic revision: r14 - 16 Apr 2011, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License