Item8321: WorkflowPlugin doesn't work for topics with non-wikiword name

pencil
Priority: Normal
Current State: Closed
Released In:
Target Release:
Applies To: Extension
Component: WorkflowPlugin
Branches:
Reported By: MartinKaufmann
Waiting For:
Last Change By: CrawfordCurrie
The latest version of WorkflowPlugin ($Rev: 5325 (2009-10-19) $) doesn't work for topics whose name is not a wiki word.

Example: I've created a topic called WorkflowTest where I set the variable WORKFLOW to the topic name of the workflow definition. As expected, this topic is now under workflow control and I'm able to change the workflow status. If I rename this topic to Test, the topic is no longer under workflow control although the META information is still the same. The same happens if I create the topic Test from scratch.

In WorkflowPlugin.pm there is a check for a valid topic name: return undef unless Foswiki::Func::isValidTopicName( $topic ); (around line 85). This check fails for non-wikiword topics. Is this check reasonable?

-- MartinKaufmann - 04 Nov 2009

see also Tasks.Item9040

-- IngoWolf - 20 May 2010

This was reported again and after due consideration, I decided to relax the constraint on workflow topic names being a valid wikiword. They must still pass the valid topic check, though.

-- CrawfordCurrie - 20 May 2010

 

ItemTemplate edit

Summary WorkflowPlugin doesn't work for topics with non-wikiword name
ReportedBy MartinKaufmann
Codebase 1.0.7
SVN Range Foswiki-1.0.7, Sun, 20 Sep 2009, build 5061
AppliesTo Extension
Component WorkflowPlugin
Priority Normal
CurrentState Closed
WaitingFor
Checkins WorkflowPlugin:0ea8ed5c0cbe
ReleasedIn
Topic revision: r6 - 22 May 2010, CrawfordCurrie
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy